-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement functions for vm #1433
Conversation
Test262 conformance changes:
|
Benchmark for b1f2b95Click to view benchmark
|
Benchmark for 46594beClick to view benchmark
|
I'll try to rebase this today :) |
7e1fcd3
to
138a530
Compare
Benchmark for 5d70616Click to view benchmark
|
Benchmark for 70332f9Click to view benchmark
|
Benchmark for 6f99c33Click to view benchmark
|
01ba07a
to
bf5fe70
Compare
Benchmark for 48d136bClick to view benchmark
|
e18aa7d
to
a56469a
Compare
Benchmark for 802ffe3Click to view benchmark
|
Benchmark for c031804Click to view benchmark
|
I'll try to rebase this today :) |
a56469a
to
54a87f9
Compare
54a87f9
to
40449af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that knowledgeable about the vm (yet), but from what I can see this looks sound.
I like the restructuring of Vm
, CallFrame
and CodeBlock
.
There are some unresolved docs links in boa/src/object/function.rs
you may want to fix.
40449af
to
cc0f49e
Compare
- Separate builtin function from rust JavaScript function - Removed BuiltInFunction struct
cc0f49e
to
418c654
Compare
Im going to merge this, its had approvals and looks good to me, |
This Pull Request fixes/closes #1430 .
It changes the following:
declaration
,expression
andarrow
functions.call()
Now we can run code like