-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor regexp costructor #1434
Conversation
Fixed tests:
Broken tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :)
Just a small change.
a0d9713
to
152f081
Compare
@HalidOdat I rebased this and implemented your suggestions. I refactored a few more things in the RegExp function directly use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
This Pull Request relates to #1304.
It changes the following:
The test
built-ins/RegExp/prototype/Symbol.split/limit-0-bail.js
is now failing, becauseRegexp[Symbol.split]
gets theflags
property from the regexp prototype, which is undefined. I'm not sure where the root cause for that is, as everything in the immediate call path seems spec compliant to me. But I think we can fix that later as the split implementation itself seems spec compliant.