Optimize integer negation #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
Test262 conformance changes:
|
HalidOdat
force-pushed
the
optimization/integer-negation
branch
from
23e99eb to
bdd3596
Compare
Benchmark for 49fececClick to view benchmark
|
Benchmark for bc2c790Click to view benchmark
|
Razican
approved these changes
Aug 18, 2021
|
Interestingly, it's failing 4 tests |
jedel1043
reviewed
Aug 19, 2021
There was a problem hiding this comment.
I extracted one of the checks in the failing test:
if (-1 % -1 !== -0) {
$ERROR('#2.1: -1 % -1 === 0. Actual: ' + (-1 % -1));
} else {
if (1 / (-1 % -1) !== Number.NEGATIVE_INFINITY) {
$ERROR('#2.2: -1 % -1 === - 0. Actual: +0');
}
}EcmaScript requires that -1 % -1 must have the information of the sign in order to return f64::NEGATIVE_INFINITY in case we divide a number by -1 % -1.
With the changes on this commit, -1i32 % -1i32 returns 0i32, making 1 / (-1 % -1) === f64::POSITIVE_INFINITY. This fails the second check.
So, to pass this test we would need to change the rem operator to return a -0.0f64 if x < 0 in x % y === 0
Nonetheless, it's still necessary to convert -0 to f64 to pass the other test.
|
Yup. The integer module operation is not spec compliant, ill try to look into it this weekend |
jedel1043
force-pushed
the
optimization/integer-negation
branch
from
bdd3596 to
f14ac7e
Compare
jedel1043
force-pushed
the
optimization/integer-negation
branch
from
f14ac7e to
10dc64b
Compare
|
Fixed the mod operator. |
raskad
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
%operator to return a number with the sign of its lhs.