Implement this expression #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,11 @@ pub trait EnvironmentRecordTrait: Debug + Trace + Finalize { | |||
| /// Return true if it does and false if it does not. | |||
| fn has_this_binding(&self) -> bool; | |||
|
|
|||
| fn get_this_binding(&self) -> Value { | |||
| debug_assert!(self.has_this_binding()); | |||
There was a problem hiding this comment.
not sure if the assert is needed?
It won't even compile if a has_this_binding() isn't implemented
There was a problem hiding this comment.
has_this_binding can return false for some environment records, although the interpreter should never call get_this_binding for them. I am asserting that invariant here.
|
We already have It would be good to see a test with constructors being used. |
|
Okay I will add a test with constructors. |
|
Now with better understanding, I reimplemented this in #185. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR here!
After playing with
boafor a while, I noticedthisis unimplemented. I tried to implement it with as minimal changes as possible, so it may not fit the overall architecture. If so, just tell me how should I update.