Adjust EnumerableOwnPropertyNames
to use all String
type property keys
#1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1501.
It changes the following:
EnumerableOwnPropertyNames
to use allString
type property keysThis looks different from the spec, because the meaning of
String
in4.a: If Type(key) is String, then
is different than our internalPropertyKey
enum typesString
,Symbol
andIndex
. Our internalIndex
type is aString
type in the context of the spec.This PR is only a fix for this specific function. We should change our
[[OwnPropertyKeys]]
to be spec compliant, but I think we should wait with that until #1354 is merged, because[[OwnPropertyKeys]]
is defined multiple times for different object types.