Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object.values() #1508

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Implement Object.values() #1508

merged 1 commit into from
Aug 24, 2021

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement Object.values()

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Aug 24, 2021
@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 24, 2021
@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 80,685 80,685 0
Passed 31,687 31,705 +18
Ignored 15,818 15,818 0
Failed 33,180 33,162 -18
Panics 2 2 0
Conformance 39.27% 39.29% +0.02%
Fixed tests:
test/built-ins/Object/values/function-length.js [strict mode] (previously Failed)
test/built-ins/Object/values/function-length.js (previously Failed)
test/built-ins/Object/values/primitive-numbers.js [strict mode] (previously Failed)
test/built-ins/Object/values/primitive-numbers.js (previously Failed)
test/built-ins/Object/values/tamper-with-object-keys.js [strict mode] (previously Failed)
test/built-ins/Object/values/tamper-with-object-keys.js (previously Failed)
test/built-ins/Object/values/function-name.js [strict mode] (previously Failed)
test/built-ins/Object/values/function-name.js (previously Failed)
test/built-ins/Object/values/primitive-booleans.js [strict mode] (previously Failed)
test/built-ins/Object/values/primitive-booleans.js (previously Failed)
test/built-ins/Object/values/symbols-omitted.js [strict mode] (previously Failed)
test/built-ins/Object/values/symbols-omitted.js (previously Failed)
test/built-ins/Object/values/inherited-properties-omitted.js [strict mode] (previously Failed)
test/built-ins/Object/values/inherited-properties-omitted.js (previously Failed)
test/built-ins/Object/values/primitive-symbols.js [strict mode] (previously Failed)
test/built-ins/Object/values/primitive-symbols.js (previously Failed)
test/built-ins/Object/values/function-property-descriptor.js [strict mode] (previously Failed)
test/built-ins/Object/values/function-property-descriptor.js (previously Failed)

@github-actions
Copy link

Benchmark for 852bd97

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 243.8±6.97ns 248.0±5.51ns -1.69%
Arithmetic operations (Full) 293.7±7.81µs 293.4±6.28µs +0.10%
Array access (Execution) 6.4±0.15µs 6.3±0.19µs +1.59%
Array access (Full) 324.1±11.32µs 319.1±8.04µs +1.57%
Array creation (Execution) 3.0±0.07ms 2.9±0.07ms +3.45%
Array creation (Full) 3.0±0.07ms 3.0±0.09ms 0.00%
Array pop (Execution) 966.4±20.17µs 961.6±29.15µs +0.50%
Array pop (Full) 1344.8±28.48µs 1356.5±30.80µs -0.86%
Boolean Object Access (Execution) 5.1±0.16µs 5.1±0.13µs 0.00%
Boolean Object Access (Full) 311.9±6.92µs 314.0±8.39µs -0.67%
Clean js (Execution) 703.3±20.05µs 710.2±17.89µs -0.97%
Clean js (Full) 1023.2±27.89µs 1035.7±30.81µs -1.21%
Clean js (Parser) 31.8±0.79µs 32.0±1.04µs -0.62%
Create Realm 393.9±11.10ns 415.1±16.02ns -5.11%
Dynamic Object Property Access (Execution) 5.0±0.12µs 5.0±0.20µs 0.00%
Dynamic Object Property Access (Full) 317.1±7.44µs 315.0±9.52µs +0.67%
Expression (Parser) 5.8±0.14µs 5.7±0.15µs +1.75%
Fibonacci (Execution) 743.7±19.37µs 766.8±18.82µs -3.01%
Fibonacci (Full) 1076.1±32.60µs 1094.5±27.27µs -1.68%
For loop (Execution) 18.6±0.51µs 18.7±0.49µs -0.53%
For loop (Full) 322.8±7.27µs 317.6±9.79µs +1.64%
For loop (Parser) 15.4±0.47µs 16.2±0.29µs -4.94%
Goal Symbols (Parser) 11.3±0.23µs 11.3±0.24µs 0.00%
Hello World (Parser) 3.3±0.10µs 3.3±0.09µs 0.00%
Long file (Parser) 744.0±17.69ns 739.6±17.48ns +0.59%
Mini js (Execution) 671.7±14.36µs 650.6±13.89µs +3.24%
Mini js (Full) 1008.6±27.36µs 967.2±21.87µs +4.28%
Mini js (Parser) 28.1±0.91µs 28.5±0.86µs -1.40%
Number Object Access (Execution) 4.0±0.12µs 4.0±0.07µs 0.00%
Number Object Access (Full) 305.8±8.02µs 313.1±8.42µs -2.33%
Object Creation (Execution) 4.4±0.12µs 4.4±0.15µs 0.00%
Object Creation (Full) 313.1±6.09µs 312.8±7.02µs +0.10%
RegExp (Execution) 12.7±1.05µs 12.3±0.27µs +3.25%
RegExp (Full) 320.1±8.98µs 330.4±8.54µs -3.12%
RegExp Literal (Execution) 12.2±0.38µs 12.3±0.49µs -0.81%
RegExp Literal (Full) 331.8±9.56µs 327.0±8.28µs +1.47%
RegExp Literal Creation (Execution) 9.0±0.28µs 8.9±0.33µs +1.12%
RegExp Literal Creation (Full) 321.2±8.24µs 314.1±8.38µs +2.26%
Static Object Property Access (Execution) 4.6±0.15µs 4.5±0.14µs +2.22%
Static Object Property Access (Full) 314.3±11.03µs 310.2±7.12µs +1.32%
String Object Access (Execution) 6.7±0.17µs 6.8±0.18µs -1.47%
String Object Access (Full) 313.3±8.83µs 313.1±7.43µs +0.06%
String comparison (Execution) 6.5±0.20µs 6.5±0.17µs 0.00%
String comparison (Full) 315.1±7.82µs 316.5±8.71µs -0.44%
String concatenation (Execution) 5.1±0.12µs 5.1±0.17µs 0.00%
String concatenation (Full) 307.2±5.48µs 305.8±8.20µs +0.46%
String copy (Execution) 3.9±0.10µs 3.9±0.10µs 0.00%
String copy (Full) 306.2±8.58µs 304.2±7.31µs +0.66%
Symbols (Execution) 3.3±0.08µs 3.3±0.11µs 0.00%
Symbols (Full) 291.6±8.38µs 289.6±6.63µs +0.69%

@HalidOdat HalidOdat merged commit f6749f9 into master Aug 24, 2021
@HalidOdat HalidOdat deleted the feature/object-values branch August 24, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant