Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Array.prototype.at() #1613

Merged
merged 18 commits into from
Oct 3, 2021
Merged

Implement Array.prototype.at() #1613

merged 18 commits into from
Oct 3, 2021

Commits on Oct 2, 2021

  1. Initial commit of comments and function

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    f8b1997 View commit details
    Browse the repository at this point in the history

  2. Adding ECMAScript step comment outlines

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b2a835f View commit details
    Browse the repository at this point in the history

  3. code written for all steps - comments reformatted

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    270508d View commit details
    Browse the repository at this point in the history

  4. Added extra | to comment

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    7464179 View commit details
    Browse the repository at this point in the history

  5. Cleaning up comments on match _ arm

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    be10c9f View commit details
    Browse the repository at this point in the history

  6. Updated top level comment block

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    db5725a View commit details
    Browse the repository at this point in the history

  7. Added at method to constructor's prototype at line 89

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    07aebb9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of https://github.com/boa-dev/boa into impl-arr… 

    …ay-prototype-at
    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    0096fd5 View commit details
    Browse the repository at this point in the history

  9. Fixing some errors involving len being usize and return type

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    138a755 View commit details
    Browse the repository at this point in the history

  10. changed relativeIndex to relative_index for rust

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    f9bb0ac View commit details
    Browse the repository at this point in the history

  11. return 0 index by default in the case of no args given

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    57b51ce View commit details
    Browse the repository at this point in the history

  12. fixed comment on change for better readability

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    1a9c4a9 View commit details
    Browse the repository at this point in the history

  13. made changes according to review feedback

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    18e26e3 View commit details
    Browse the repository at this point in the history

  14. updated comment block lines for readability

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    224dc93 View commit details
    Browse the repository at this point in the history

  15. adding match guard update - removes need of step 6

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    e11bfc4 View commit details
    Browse the repository at this point in the history

  16. clean up comments on match guards

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    753f517 View commit details
    Browse the repository at this point in the history

  17. fixing potential match bug involving arg being len

    @nekevss
    nekevss committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    1acc870 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. logic update to match guard on second arm for readability

    @nekevss
    nekevss committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    0a6d4eb View commit details
    Browse the repository at this point in the history