[Merged by Bors] - Implement prototype of Intl built-in
#1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
jedel1043
reviewed
Oct 3, 2021
jedel1043
reviewed
Oct 3, 2021
jedel1043
reviewed
Oct 3, 2021
jedel1043
reviewed
Oct 3, 2021
jedel1043
reviewed
Oct 3, 2021
jedel1043
reviewed
Oct 3, 2021
Co-authored-by: jedel1043 <jedel0124@gmail.com>
|
Ah, you have to |
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Test262 conformance changes:
Fixed tests (74): |
jedel1043
reviewed
Oct 4, 2021
jedel1043
reviewed
Oct 4, 2021
Co-authored-by: jedel1043 <jedel0124@gmail.com>
Co-authored-by: jedel1043 <jedel0124@gmail.com>
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
jedel1043
approved these changes
Oct 4, 2021
jedel1043
added
builtins
raskad
approved these changes
Oct 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 44.40% 50.91% +6.51%
==========================================
Files 203 199 -4
Lines 20270 17707 -2563
==========================================
+ Hits 9000 9016 +16
+ Misses 11270 8691 -2579
Continue to review full report at Codecov.
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2021
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This pull request is related to #1180. It changes the following: - Creates the `Intl` global - Adds the `Intl.getCanonicalLocales` method At the moment it does not actually use ICU4X behind the scenes; `Intl.getCanonicalLocales` simply acts as if all the locales passed are canonical locales. This will not be the case in the final PR. Co-authored-by: RageKnify <RageKnify@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2021
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This pull request is related to #1180. It changes the following: - Creates the `Intl` global - Adds the `Intl.getCanonicalLocales` method At the moment it does not actually use ICU4X behind the scenes; `Intl.getCanonicalLocales` simply acts as if all the locales passed are canonical locales. This will not be the case in the final PR. Co-authored-by: RageKnify <RageKnify@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Intl built-in Intl built-in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #1180.
It changes the following:
IntlglobalIntl.getCanonicalLocalesmethodAt the moment it does not actually use ICU4X behind the scenes;
Intl.getCanonicalLocalessimply acts as if all the locales passed are canonical locales. This will not be the case in the final PR.