Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Symbol.prototype[ @@toPrimitive ] #1634

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Implement Symbol.prototype[ @@toPrimitive ] #1634

merged 3 commits into from
Oct 5, 2021

Conversation

Nimpruda
Copy link
Contributor

@Nimpruda Nimpruda commented Oct 5, 2021

This Pull Request fixes/closes #1233 .

It adds Symbol.prototype[ @@toPrimitive ]

Razican
Razican approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me! Let's wait for the CI pipeline :)

@Razican Razican added this to the v0.14.0 milestone Oct 5, 2021
@Nimpruda
Copy link
Contributor Author

Nimpruda commented Oct 5, 2021 •
edited
Loading

Oops I forgot to re run rustfmt I'll do this in a minute. I feel bad for wasting CI time for this 😭.

@Nimpruda
Copy link
Contributor Author

Nimpruda commented Oct 5, 2021 •
edited
Loading

The tests in built-ins/Symbol/prototype/Symbol.toPrimitive/ all pass except these in removed-symbol-wrapper-ordinary-toprimitive.js. I don't think it is a problem with what I implemented but rather with the OrdinaryToPrimitive implementation on Object. I'm not sure tho.

jedel1043
jedel1043 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043
Copy link
Member

The tests in built-ins/Symbol/prototype/Symbol.toPrimitive/ all pass except these in removed-symbol-wrapper-ordinary-toprimitive.js. I don't think it is a problem with what I implemented but rather with the OrdinaryToPrimitive implementation on Object. I'm not sure tho.

Probably, we'll have to investigate what causes this.

@jedel1043 jedel1043 added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Oct 5, 2021
@jedel1043 jedel1043 merged commit 8826c6d into boa-dev:master Oct 5, 2021
@Nimpruda Nimpruda deleted the implement-symbol branch October 5, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Implement Symbol.prototype[ @@toPrimitive ]( hint )
3 participants
@Nimpruda @jedel1043 @Razican