[Merged by Bors] - First prototype for new JsString using UTF-16
#1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition, the utf16_literal crate should be useful to convert runtime strings from |
Test262 conformance changesVM implementation
Fixed tests (30):Broken tests (8): |
Codecov Report
@@ Coverage Diff @@
## main #1659 +/- ##
==========================================
- Coverage 40.93% 40.82% -0.11%
==========================================
Files 238 240 +2
Lines 22509 22743 +234
==========================================
+ Hits 9214 9285 +71
- Misses 13295 13458 +163
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark for 4aee7ceClick to view benchmark
|
|
Hi @jedel1043! Do you think you would be able to get back to this? This would be very nice to have :) |
|
I'm still working on it locally :) |
Benchmark for f902625Click to view benchmark
|
Benchmark for c3d66b0Click to view benchmark
|
|
Time to see how many tests break... 😅 |
jedel1043
force-pushed
the
utf16-str
branch
5 times, most recently
from
69b3ce9 to
cdb7d38
Compare
|
Well, I expected to see more failed tests tbh, I'll probably fix those today or tomorrow. It could also be that we cannot parse string literals with UTF-16 codepoints; the interner automatically converts unpaired surrogates to On another note, the interner doesn't support UTF-16 strings, so we will need to contribute to |
Yes, but they might not want to add this feature, so we might end up needing to write our own interner. Let's see if we can open them an issue. |
jedel1043
force-pushed
the
utf16-str
branch
6 times, most recently
from
a89d440 to
70eca88
Compare
Benchmark for c115fd5Click to view benchmark
|
Benchmark for 14d3cf4Click to view benchmark
|
Razican
approved these changes
Oct 11, 2022
Benchmark for 5dd62b2Click to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
I think it's time to address the elephant in the room. This Pull Request will (hopefully!) solve part of #736. This is a complete rewrite of `JsString`, but instead of storing `u8` bytes it stores `u16` words. The `encode!` macro (renamed to `utf16!` for simplicity) from the `const-utf16` crate allows us to create UTF-16 encoded arrays at compilation time. `JsString` implements `Deref<Target=[u16]>` to unlock the slice methods and possibly make some manipulations easier. However, we would need to create our own library of utilities for `JsString`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
JsString using UTF-16 JsString using UTF-16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to address the elephant in the room.
This Pull Request will (hopefully!) solve part of #736.
This is a complete rewrite of
JsString, but instead of storingu8bytes it storesu16words. Theencode!macro (renamed toutf16!for simplicity) from theconst-utf16crate allows us to create UTF-16 encoded arrays at compilation time.JsStringimplementsDeref<Target=[u16]>to unlock the slice methods and possibly make some manipulations easier. However, we would need to create our own library of utilities forJsString.