-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Array findLast and findLastIndex #1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just some small nitpicks that are easily solvable. Everything else looks good!
Test262 conformance changes:
Fixed tests (50):
|
Thanks for the suggestions! They should all be updated now. I left the comments as-is, the implementation is different but at least they show how it matches up with the proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me 😁
This Pull Request closes #1654.
It changes the following:
Array.prototype.findLast
Array.prototype.findLastIndex
.