-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Adding VM conformance output to PR checks #1685
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
==========================================
+ Coverage 44.40% 50.91% +6.51%
==========================================
Files 203 199 -4
Lines 20270 17709 -2561
==========================================
+ Hits 9000 9016 +16
+ Misses 11270 8693 -2577
Continue to review full report at Codecov.
|
Is it possible to run the VM tests only if the |
I think we can have the CI rule only match if the PR's branch name includes the letters |
I wouldn't do this, as some changes to the non-vm modules will also affect the conformance of the vm feature. |
the path of the json with the base results was used, but I'm pretty sure we can just start with an empty path instead
Test262 conformance changesNon-VM implementation
VM implementation
|
Looks good to me :) let's see if it works properly going forward! |
bors r+ |
This PR adds conformance results for the VM branch both for PRs and for the conformance results in GitHub pages (even if these are not currently being shown). I'm not 100% sure how this will really work, as I'm not very used to the syntax to concatenate strings. Co-authored-by: João Borges <rageknify@gmail.com> Co-authored-by: RageKnify <RageKnify@gmail.com>
Build failed: |
bors retry |
This PR adds conformance results for the VM branch both for PRs and for the conformance results in GitHub pages (even if these are not currently being shown). I'm not 100% sure how this will really work, as I'm not very used to the syntax to concatenate strings. Co-authored-by: João Borges <rageknify@gmail.com> Co-authored-by: RageKnify <RageKnify@gmail.com>
Pull request successfully merged into main. Build succeeded: |
This PR adds conformance results for the VM branch both for PRs and for the conformance results in GitHub pages (even if these are not currently being shown). I'm not 100% sure how this will really work, as I'm not very used to the syntax to concatenate strings.