-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement missing vm operations #1697
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
- Coverage 50.85% 49.95% -0.90%
==========================================
Files 199 200 +1
Lines 17803 18130 +327
==========================================
+ Hits 9053 9057 +4
- Misses 8750 9073 +323
Continue to review full report at Codecov.
|
Non-VM implementation
VM implementation
|
Relevant for the review may be this change outside of the vm: I moved the early error generation for declarations in boa/src/syntax/ast/node/iteration/for_in_loop/mod.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing just to indicate that the DefConst
opcode should be removed.
bors r+ |
This implements most of the missing vm operations and fixes most of the panics. The early errors for declarations in `for in` and `for of` loops are moved to the parser. The content of those `Node`s is changed accordingly.
Pull request successfully merged into main. Build succeeded: |
This implements most of the missing vm operations and fixes most of the panics.
The early errors for declarations in
for in
andfor of
loops are moved to the parser. The content of thoseNode
s is changed accordingly.