[Merged by Bors] - Generic JsResult<R> in context.throw_ methods

[HalidOdat]

Previously when we had the context.throw_ methods (like context.thtrow_type_error()) they were limited as to where we could call them, e.i. a function that returned JsResult<JsValue>. So we had to call the context.construct_ methods with an explicit Err() enum wrap to throw in functions that returned non-jsvalues (which happens a lot).
Now, with this PR the throw methods have a generic JsResult<R> return that can return in any JsResult<T> returning function. Which cleans the API and makes the user experience a bit better.

return Err(context.construct_type_error("..."));
// to
return context.throw_type_error("...");

[github-actions]

Test262 conformance changes

Non-VM implementation

Test result	main count	PR count	difference
Total	86,952	86,952	0
Passed	40,111	40,111	0
Ignored	19,269	19,269	0
Failed	27,572	27,572	0
Panics	0	0	0
Conformance	46.13%	46.13%	0.00%

VM implementation

Test result	main count	PR count	difference
Total	86,952	86,952	0
Passed	39,654	39,654	0
Ignored	19,269	19,269	0
Failed	28,029	28,029	0
Panics	189	189	0
Conformance	45.60%	45.60%	0.00%

[codecov]

Codecov Report

Merging #1734 (5fcf232) into main (e1b2abb) will increase coverage by 0.04%.
The diff coverage is 15.68%.

@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
+ Coverage   53.33%   53.38%   +0.04%     
==========================================
  Files         200      200              
  Lines       16983    16967      -16     
==========================================
- Hits         9058     9057       -1     
+ Misses       7925     7910      -15     

Impacted Files	Coverage Δ
boa/src/builtins/array/mod.rs	77.76% <0.00%> (ø)
boa/src/builtins/array_buffer/mod.rs	6.77% <0.00%> (ø)
boa/src/builtins/intl/mod.rs	19.35% <0.00%> (ø)
boa/src/builtins/iterable/mod.rs	61.64% <0.00%> (ø)
boa/src/builtins/number/mod.rs	79.55% <0.00%> (ø)
boa/src/builtins/typed_array/mod.rs	3.79% <0.00%> (ø)
.../src/environment/declarative_environment_record.rs	65.07% <0.00%> (ø)
boa/src/environment/global_environment_record.rs	40.56% <0.00%> (ø)
boa/src/environment/object_environment_record.rs	25.58% <0.00%> (ø)
boa/src/object/internal_methods/array.rs	76.56% <0.00%> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b2abb...5fcf232. Read the comment docs.

[Razican]

Thanks! For a second there I thought we already had this, but indeed, this extra generic parameter makes it much more useful, since it can basically be used everywhere.

I'm approving the PR, even if there seems to be something strange with the test suite. Could you check that? Maybe the sub-module needs updating.

[HalidOdat]

I'm approving the PR, even if there seems to be something strange with the test suite. Could you check that? Maybe the sub-module needs updating.

Yes, it was out of date, I updated it and committed it :)

[RageKnify]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on Linux with vm enabled
• Tests on MacOS
• Tests on Windows