Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement String.raw( template, ...substitutions ) #1741

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement String.raw( template, ...substitutions ) #1741

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement String.raw( template, ...substitutions )

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Dec 14, 2021
@HalidOdat HalidOdat added this to the v0.14.0 milestone Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1741 (3f8043d) into main (6cb93cf) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
- Coverage   53.08%   53.03%   -0.06%     
==========================================
  Files         200      200              
  Lines       17059    17076      +17     
==========================================
  Hits         9056     9056              
- Misses       8003     8020      +17
Impacted Files Coverage Δ
boa/src/builtins/string/mod.rs 63.94% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb93cf...3f8043d. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited by Razican
Loading

Test262 conformance changes

Non-VM implementation

Test result main count PR count difference
Total 86,952 86,952 0
Passed 40,111 40,157 +46
Ignored 19,269 19,269 0
Failed 27,572 27,526 -46
Panics 0 0 0
Conformance 46.13% 46.18% +0.05%
Fixed tests (46): 
test/built-ins/String/raw/return-the-string-value.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-the-string-value.js (previously Failed)
test/built-ins/String/raw/substitutions-are-limited-to-template-raw-length.js [strict mode] (previously Failed)
test/built-ins/String/raw/substitutions-are-limited-to-template-raw-length.js (previously Failed)
test/built-ins/String/raw/template-substitutions-are-appended-on-same-index.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-substitutions-are-appended-on-same-index.js (previously Failed)
test/built-ins/String/raw/template-raw-throws.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-raw-throws.js (previously Failed)
test/built-ins/String/raw/raw.js [strict mode] (previously Failed)
test/built-ins/String/raw/raw.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-negative-infinity.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-negative-infinity.js (previously Failed)
test/built-ins/String/raw/template-length-throws.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-length-throws.js (previously Failed)
test/built-ins/String/raw/zero-literal-segments.js [strict mode] (previously Failed)
test/built-ins/String/raw/zero-literal-segments.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-not-defined.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-not-defined.js (previously Failed)
test/built-ins/String/raw/return-empty-string-from-empty-array-length.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-from-empty-array-length.js (previously Failed)
test/built-ins/String/raw/return-the-string-value-from-template.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-the-string-value-from-template.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-null.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-null.js (previously Failed)
test/built-ins/String/raw/name.js [strict mode] (previously Failed)
test/built-ins/String/raw/name.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key-toString.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key-toString.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-substitution.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-substitution.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-number.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-number.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-boolean.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-boolean.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-NaN.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-NaN.js (previously Failed)
test/built-ins/String/raw/substitutions-are-appended-on-same-index.js [strict mode] (previously Failed)
test/built-ins/String/raw/substitutions-are-appended-on-same-index.js (previously Failed)
test/built-ins/String/raw/length.js [strict mode] (previously Failed)
test/built-ins/String/raw/length.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-string.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-string.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-undefined.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-undefined.js (previously Failed)

VM implementation

Test result main count PR count difference
Total 86,952 86,952 0
Passed 40,801 40,847 +46
Ignored 19,269 19,269 0
Failed 26,882 26,836 -46
Panics 0 0 0
Conformance 46.92% 46.98% +0.05%
Fixed tests (46): 
test/built-ins/String/raw/return-the-string-value.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-the-string-value.js (previously Failed)
test/built-ins/String/raw/substitutions-are-limited-to-template-raw-length.js [strict mode] (previously Failed)
test/built-ins/String/raw/substitutions-are-limited-to-template-raw-length.js (previously Failed)
test/built-ins/String/raw/template-substitutions-are-appended-on-same-index.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-substitutions-are-appended-on-same-index.js (previously Failed)
test/built-ins/String/raw/template-raw-throws.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-raw-throws.js (previously Failed)
test/built-ins/String/raw/raw.js [strict mode] (previously Failed)
test/built-ins/String/raw/raw.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-negative-infinity.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-negative-infinity.js (previously Failed)
test/built-ins/String/raw/template-length-throws.js [strict mode] (previously Failed)
test/built-ins/String/raw/template-length-throws.js (previously Failed)
test/built-ins/String/raw/zero-literal-segments.js [strict mode] (previously Failed)
test/built-ins/String/raw/zero-literal-segments.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-not-defined.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-not-defined.js (previously Failed)
test/built-ins/String/raw/return-empty-string-from-empty-array-length.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-from-empty-array-length.js (previously Failed)
test/built-ins/String/raw/return-the-string-value-from-template.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-the-string-value-from-template.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-null.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-null.js (previously Failed)
test/built-ins/String/raw/name.js [strict mode] (previously Failed)
test/built-ins/String/raw/name.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key-toString.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key-toString.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-substitution.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-substitution.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-number.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-number.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-boolean.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-boolean.js (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key.js [strict mode] (previously Failed)
test/built-ins/String/raw/returns-abrupt-from-next-key.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-NaN.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-NaN.js (previously Failed)
test/built-ins/String/raw/substitutions-are-appended-on-same-index.js [strict mode] (previously Failed)
test/built-ins/String/raw/substitutions-are-appended-on-same-index.js (previously Failed)
test/built-ins/String/raw/length.js [strict mode] (previously Failed)
test/built-ins/String/raw/length.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-string.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-zero-or-less-string.js (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-undefined.js [strict mode] (previously Failed)
test/built-ins/String/raw/return-empty-string-if-length-is-undefined.js (previously Failed)

@HalidOdat
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 14, 2021
@HalidOdat
Implement String.raw( template, ...substitutions ) (#1741)
ace98f8 
It changes the following:
- Implement `String.raw( template, ...substitutions )`
@bors
Copy link

bors bot commented Dec 14, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement String.raw( template, ...substitutions ) [Merged by Bors] - Implement String.raw( template, ...substitutions ) Dec 14, 2021
@bors bors bot closed this Dec 14, 2021
@bors bors bot deleted the feature/string-raw branch December 14, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@RageKnify RageKnify RageKnify approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @jasonwilliams @RageKnify