Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Using production builds for WebAssembly #1825

Closed
wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Feb 6, 2022

This commit selects the production build (instead of development) for the WebAssembly compilation with Webpack, used in our playground. This might make things a bit faster and smaller.

I also took the opportunity to update all the dependencies and the Test262 suite, but unfortunately this doesn't solve #1824.

This commit selects the production build (instead of development) for
the WebAssembly compilation with Webpack, used in our playground. This
might make things a bit faster and smaller.

I also took the opportunity to update all the dependencies and the Test262
suite, but unfortunately this doesn't solve #1824.
@Razican Razican added performance Performance related changes and issues dependencies Pull requests that update a dependency file test Issues and PRs related to the tests. webassembly Anything related to using Boa with WASM labels Feb 6, 2022
@Razican Razican added this to the v0.14.0 milestone Feb 6, 2022
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 87,650 87,912 +262
Passed 40,892 40,892 0
Ignored 19,675 19,929 +254
Failed 27,083 27,091 +8
Panics 0 0 0
Conformance 46.65% 46.51% -0.14%

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #1825 (5690d62) into main (b34d581) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files         201      201           
  Lines       17326    17326           
=======================================
  Hits         9656     9656           
  Misses       7670     7670           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34d581...5690d62. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Benchmark for 7c61550

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 459.5±29.68ns 453.4±39.34ns -1.33%
Arithmetic operations (Execution) 2.0±0.14µs 1975.3±108.08ns -1.23%
Arithmetic operations (Parser) 5.9±0.33µs 6.0±0.43µs +1.69%
Array access (Compiler) 988.9±54.27ns 958.7±60.30ns -3.05%
Array access (Execution) 11.1±0.67µs 11.4±0.87µs +2.70%
Array access (Parser) 12.5±1.03µs 12.7±1.04µs +1.60%
Array creation (Compiler) 1385.9±109.10ns 1308.9±90.96ns -5.56%
Array creation (Execution) 3.3±0.22ms 3.1±0.18ms -6.06%
Array creation (Parser) 14.0±0.86µs 14.0±0.96µs 0.00%
Array pop (Compiler) 3.1±0.23µs 3.1±0.24µs 0.00%
Array pop (Execution) 1358.6±62.39µs 1302.2±76.62µs -4.15%
Array pop (Parser) 159.7±9.69µs 151.2±9.90µs -5.32%
Boolean Object Access (Compiler) 833.8±51.88ns 789.7±46.57ns -5.29%
Boolean Object Access (Execution) 7.6±0.43µs 7.5±0.49µs -1.32%
Boolean Object Access (Parser) 14.7±1.25µs 15.4±0.97µs +4.76%
Clean js (Compiler) 2.6±0.17µs 2.4±0.16µs -7.69%
Clean js (Execution) 1525.2±96.33µs 1530.3±76.19µs +0.33%
Clean js (Parser) 29.7±1.87µs 30.0±2.11µs +1.01%
Create Realm 371.9±30.53ns 341.3±18.98ns -8.23%
Dynamic Object Property Access (Compiler) 1339.3±95.14ns 1294.9±87.43ns -3.32%
Dynamic Object Property Access (Execution) 7.4±0.48µs 7.8±0.59µs +5.41%
Dynamic Object Property Access (Parser) 11.3±0.93µs 11.2±0.77µs -0.88%
Fibonacci (Compiler) 1797.6±120.78ns 1704.7±116.79ns -5.17%
Fibonacci (Execution) 3.3±0.18ms 3.4±0.21ms +3.03%
Fibonacci (Parser) 17.0±1.42µs 17.8±1.19µs +4.71%
For loop (Compiler) 1505.9±88.41ns 1455.9±94.11ns -3.32%
For loop (Execution) 49.6±4.67µs 47.4±2.80µs -4.44%
For loop (Parser) 14.7±1.43µs 15.3±1.51µs +4.08%
Mini js (Compiler) 2.5±0.14µs 2.5±0.18µs 0.00%
Mini js (Execution) 1403.9±83.32µs 1357.9±89.02µs -3.28%
Mini js (Parser) 26.2±2.21µs 27.8±1.93µs +6.11%
Number Object Access (Compiler) 737.0±57.14ns 737.8±56.69ns +0.11%
Number Object Access (Execution) 5.8±0.37µs 5.8±0.40µs 0.00%
Number Object Access (Parser) 11.7±0.88µs 11.7±0.83µs 0.00%
Object Creation (Compiler) 1173.9±82.12ns 1148.9±104.77ns -2.13%
Object Creation (Execution) 7.0±0.55µs 6.7±0.33µs -4.29%
Object Creation (Parser) 9.7±0.96µs 9.7±0.91µs 0.00%
RegExp (Compiler) 1371.2±89.12ns 1273.6±53.79ns -7.12%
RegExp (Execution) 14.6±1.70µs 14.3±0.99µs -2.05%
RegExp (Parser) 10.8±0.90µs 10.1±0.58µs -6.48%
RegExp Creation (Compiler) 1223.1±97.54ns 1178.3±98.04ns -3.66%
RegExp Creation (Execution) 10.3±0.66µs 10.2±0.61µs -0.97%
RegExp Creation (Parser) 8.7±0.56µs 9.1±0.64µs +4.60%
RegExp Literal (Compiler) 1355.4±96.90ns 1312.0±93.11ns -3.20%
RegExp Literal (Execution) 14.0±0.91µs 13.5±0.79µs -3.57%
RegExp Literal (Parser) 8.5±0.69µs 8.9±1.49µs +4.71%
RegExp Literal Creation (Compiler) 1198.0±76.51ns 1154.2±62.77ns -3.66%
RegExp Literal Creation (Execution) 10.4±0.84µs 10.0±0.57µs -3.85%
RegExp Literal Creation (Parser) 6.7±0.44µs 6.6±0.37µs -1.49%
Static Object Property Access (Compiler) 1182.7±79.60ns 1112.5±65.31ns -5.94%
Static Object Property Access (Execution) 7.1±0.53µs 7.5±0.66µs +5.63%
Static Object Property Access (Parser) 10.8±1.47µs 10.2±0.70µs -5.56%
String Object Access (Compiler) 1164.9±77.21ns 1128.6±74.24ns -3.12%
String Object Access (Execution) 9.6±0.64µs 9.4±0.60µs -2.08%
String Object Access (Parser) 14.5±1.29µs 14.9±1.32µs +2.76%
String comparison (Compiler) 1617.6±129.38ns 1435.5±91.59ns -11.26%
String comparison (Execution) 7.8±0.45µs 8.2±0.80µs +5.13%
String comparison (Parser) 11.8±1.11µs 11.4±0.64µs -3.39%
String concatenation (Compiler) 1248.6±76.44ns 1206.9±75.17ns -3.34%
String concatenation (Execution) 6.9±0.59µs 7.0±0.50µs +1.45%
String concatenation (Parser) 7.8±0.49µs 7.8±0.57µs 0.00%
String copy (Compiler) 1046.5±73.02ns 1029.3±71.19ns -1.64%
String copy (Execution) 6.2±0.47µs 6.0±0.59µs -3.23%
String copy (Parser) 6.1±0.57µs 5.9±0.40µs -3.28%
Symbols (Compiler) 827.1±207.93ns 803.4±54.41ns -2.87%
Symbols (Execution) 5.9±0.46µs 5.8±0.42µs -1.69%
Symbols (Parser) 4.6±0.34µs 4.5±0.33µs -2.17%

@Razican
Copy link
Member Author

Razican commented Feb 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2022
This commit selects the production build (instead of development) for the WebAssembly compilation with Webpack, used in our playground. This might make things a bit faster and smaller.

I also took the opportunity to update all the dependencies and the Test262 suite, but unfortunately this doesn't solve #1824.
@bors
Copy link

bors bot commented Feb 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Using production builds for WebAssembly [Merged by Bors] - Using production builds for WebAssembly Feb 7, 2022
@bors bors bot closed this Feb 7, 2022
@bors bors bot deleted the updates_improvements branch February 7, 2022 17:57
@RageKnify RageKnify added the enhancement New feature or request label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request performance Performance related changes and issues test Issues and PRs related to the tests. webassembly Anything related to using Boa with WASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants