-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Using the new formatting arguments from Rust 1.58 #1834
Conversation
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 55.71% 55.75% +0.03%
==========================================
Files 201 201
Lines 17326 17273 -53
==========================================
- Hits 9654 9631 -23
+ Misses 7672 7642 -30
Continue to review full report at Codecov.
|
Benchmark for 6268410Click to view benchmark
|
Benchmark for 9d58ca2Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
bors r+ |
In [Rust 1.58](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings), capturing of bindings were added to format strings. This makes things more clear, so I added this where possible.
Pull request successfully merged into main. Build succeeded: |
In Rust 1.58, capturing of bindings were added to format strings. This makes things more clear, so I added this where possible.