[Merged by Bors] - Ignore wastefull RegExp tests
#1840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
test
Test262 conformance changesVM implementation
|
raskad
requested review from
HalidOdat,
jasonwilliams,
jedel1043,
RageKnify and
Razican
Codecov Report
@@ Coverage Diff @@
## main #1840 +/- ##
=======================================
Coverage 55.67% 55.67%
=======================================
Files 201 201
Lines 17375 17375
=======================================
Hits 9674 9674
Misses 7701 7701 Continue to review full report at Codecov.
|
Benchmark for 05eeb00Click to view benchmark
|
RageKnify
approved these changes
Feb 16, 2022
Razican
approved these changes
Feb 16, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
With the implementation of `String.fromCodePoint` in #1123 some `RegExp` tests are now running for a long time. These tests check every unicode codepoint for all regexp property escape/character classes. This not only makes the developer experience significantly worse, but also wastes cpu resources for the benefit of "completeness". I think these tests are completely useless. Ironically the unicode tables in the tests are generated - from the same data, that the unicode tables in the regex engine are also generated. 262 suite runtime: Before: ~03:30 https://github.com/boa-dev/boa/runs/5191567446?check_suite_focus=true After: ~31:00 https://github.com/boa-dev/boa/runs/5196405437?check_suite_focus=true
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
RegExp testsRegExp tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the implementation of
String.fromCodePointin #1123 someRegExptests are now running for a long time. These tests check every unicode codepoint for all regexp property escape/character classes.This not only makes the developer experience significantly worse, but also wastes cpu resources for the benefit of "completeness". I think these tests are completely useless. Ironically the unicode tables in the tests are generated - from the same data, that the unicode tables in the regex engine are also generated.
262 suite runtime:
Before: ~03:30 https://github.com/boa-dev/boa/runs/5191567446?check_suite_focus=true
After: ~31:00 https://github.com/boa-dev/boa/runs/5196405437?check_suite_focus=true