Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix wasm use outside browsers #1846

Closed
wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Feb 18, 2022

This Pull Request fixes/closes #1670.

It changes the following:

  • Removes the "js" feature by default from getrandom for wasm (still there for boa_wasm)
  • Updates dependencies

Note that this change was introduced in #1521, after #1475. We must make sure that the issue doesn't come back.

@Razican Razican added dependencies Pull requests that update a dependency file webassembly Anything related to using Boa with WASM labels Feb 18, 2022
@Razican Razican added this to the v0.14.0 milestone Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1846 (e644f61) into main (e800283) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   55.60%   55.60%           
=======================================
  Files         201      201           
  Lines       17397    17397           
=======================================
  Hits         9674     9674           
  Misses       7723     7723           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e800283...e644f61. Read the comment docs.

@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 87,912 87,912 0
Passed 40,956 40,956 0
Ignored 21,153 21,153 0
Failed 25,803 25,803 0
Panics 0 0 0
Conformance 46.59% 46.59% 0.00%

@github-actions
Copy link

Benchmark for b2e87bb

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 369.4±1.23ns 383.4±1.01ns +3.79%
Arithmetic operations (Execution) 1725.4±55.61ns 1727.3±2.67ns +0.11%
Arithmetic operations (Parser) 5.8±0.02µs 5.7±0.01µs -1.72%
Array access (Compiler) 789.3±2.11ns 893.5±35.65ns +13.20%
Array access (Execution) 10.7±0.03µs 10.9±0.04µs +1.87%
Array access (Parser) 12.8±0.03µs 12.9±0.07µs +0.78%
Array creation (Compiler) 1176.0±3.07ns 1383.3±8.46ns +17.63%
Array creation (Execution) 3.2±0.03ms 3.2±0.01ms 0.00%
Array creation (Parser) 14.2±0.03µs 14.1±0.04µs -0.70%
Array pop (Compiler) 2.7±0.01µs 2.9±0.06µs +7.41%
Array pop (Execution) 1375.8±4.56µs 1393.4±4.18µs +1.28%
Array pop (Parser) 145.7±0.24µs 144.3±0.21µs -0.96%
Boolean Object Access (Compiler) 684.8±1.53ns 691.0±1.32ns +0.91%
Boolean Object Access (Execution) 6.9±0.02µs 7.5±0.15µs +8.70%
Boolean Object Access (Parser) 14.5±0.09µs 14.4±0.06µs -0.69%
Clean js (Compiler) 2.2±0.00µs 2.3±0.05µs +4.55%
Clean js (Execution) 1468.1±8.53µs 1461.3±19.88µs -0.46%
Clean js (Parser) 31.0±0.11µs 30.1±0.13µs -2.90%
Create Realm 333.0±6.03ns 321.5±3.52ns -3.45%
Dynamic Object Property Access (Compiler) 1154.5±2.69ns 1283.4±36.11ns +11.17%
Dynamic Object Property Access (Execution) 6.9±0.04µs 6.8±0.05µs -1.45%
Dynamic Object Property Access (Parser) 11.6±0.07µs 11.5±0.07µs -0.86%
Fibonacci (Compiler) 1425.6±2.49ns 1530.3±35.50ns +7.34%
Fibonacci (Execution) 2.8±0.00ms 2.8±0.02ms 0.00%
Fibonacci (Parser) 17.3±0.08µs 17.0±0.11µs -1.73%
For loop (Compiler) 1333.5±4.06ns 1507.8±4.95ns +13.07%
For loop (Execution) 40.9±0.13µs 40.9±0.09µs 0.00%
For loop (Parser) 14.9±0.07µs 14.9±0.08µs 0.00%
Mini js (Compiler) 2.2±0.01µs 2.3±0.04µs +4.55%
Mini js (Execution) 1361.3±8.70µs 1371.2±8.30µs +0.73%
Mini js (Parser) 27.2±0.12µs 26.5±0.08µs -2.57%
Number Object Access (Compiler) 636.8±2.25ns 669.3±1.46ns +5.10%
Number Object Access (Execution) 5.4±0.01µs 5.7±0.08µs +5.56%
Number Object Access (Parser) 11.3±0.09µs 11.2±0.01µs -0.88%
Object Creation (Compiler) 974.1±2.58ns 1122.6±17.98ns +15.24%
Object Creation (Execution) 6.2±0.03µs 6.3±0.05µs +1.61%
Object Creation (Parser) 10.0±0.06µs 10.1±0.08µs +1.00%
RegExp (Compiler) 1167.6±3.39ns 1276.5±37.66ns +9.33%
RegExp (Execution) 12.9±0.08µs 13.1±0.03µs +1.55%
RegExp (Parser) 10.8±0.07µs 10.8±0.07µs 0.00%
RegExp Creation (Compiler) 1019.9±3.66ns 1167.4±34.50ns +14.46%
RegExp Creation (Execution) 9.7±0.05µs 9.8±0.05µs +1.03%
RegExp Creation (Parser) 9.1±0.06µs 9.1±0.05µs 0.00%
RegExp Literal (Compiler) 1169.6±3.98ns 1340.0±5.95ns +14.57%
RegExp Literal (Execution) 12.9±0.03µs 13.1±0.03µs +1.55%
RegExp Literal (Parser) 8.8±0.04µs 8.8±0.05µs 0.00%
RegExp Literal Creation (Compiler) 1023.5±2.95ns 1171.7±28.42ns +14.48%
RegExp Literal Creation (Execution) 9.7±0.05µs 9.7±0.05µs 0.00%
RegExp Literal Creation (Parser) 7.0±0.04µs 7.0±0.06µs 0.00%
Static Object Property Access (Compiler) 983.6±2.79ns 1149.6±26.19ns +16.88%
Static Object Property Access (Execution) 6.4±0.02µs 6.4±0.04µs 0.00%
Static Object Property Access (Parser) 10.8±0.07µs 10.7±0.07µs -0.93%
String Object Access (Compiler) 1024.4±6.60ns 1128.2±57.56ns +10.13%
String Object Access (Execution) 9.2±0.10µs 9.8±0.04µs +6.52%
String Object Access (Parser) 14.2±0.10µs 14.1±0.12µs -0.70%
String comparison (Compiler) 1309.7±4.76ns 1498.5±17.88ns +14.42%
String comparison (Execution) 7.3±0.03µs 7.4±0.05µs +1.37%
String comparison (Parser) 12.0±0.12µs 11.7±0.20µs -2.50%
String concatenation (Compiler) 1042.2±3.21ns 1256.8±10.18ns +20.59%
String concatenation (Execution) 6.2±0.02µs 6.2±0.06µs 0.00%
String concatenation (Parser) 8.4±0.06µs 8.1±0.05µs -3.57%
String copy (Compiler) 881.1±2.78ns 1054.5±9.93ns +19.68%
String copy (Execution) 5.3±0.02µs 5.3±0.04µs 0.00%
String copy (Parser) 6.3±0.04µs 6.1±0.04µs -3.17%
Symbols (Compiler) 635.7±1.60ns 684.6±30.10ns +7.69%
Symbols (Execution) 5.1±0.03µs 5.0±0.04µs -1.96%
Symbols (Parser) 4.6±0.06µs 4.5±0.07µs -2.17%

@RageKnify RageKnify added the bug Something isn't working label Feb 19, 2022
@RageKnify RageKnify changed the title Fixed #1670 Fix wasm use outside browsers Feb 19, 2022
@Razican
Copy link
Member Author

Razican commented Feb 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 20, 2022
This Pull Request fixes/closes #1670.

It changes the following:

- Removes the "js" feature by default from getrandom for wasm (still there for boa_wasm)
- Updates dependencies

Note that this change was introduced in #1521, after #1475. We must make sure that the issue doesn't come back.
@bors
Copy link

bors bot commented Feb 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix wasm use outside browsers [Merged by Bors] - Fix wasm use outside browsers Feb 20, 2022
@bors bors bot closed this Feb 20, 2022
@bors bors bot deleted the wasm_no_browser branch February 20, 2022 22:11
Razican added a commit that referenced this pull request Feb 21, 2022
This Pull Request fixes/closes #1670.

It changes the following:

- Removes the "js" feature by default from getrandom for wasm (still there for boa_wasm)
- Updates dependencies

Note that this change was introduced in #1521, after #1475. We must make sure that the issue doesn't come back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file webassembly Anything related to using Boa with WASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use in wasmtime or outside of browser
3 participants