[Merged by Bors] - Correct reference error message #1855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1855 +/- ##
=======================================
Coverage 55.27% 55.27%
=======================================
Files 200 200
Lines 17861 17860 -1
=======================================
Hits 9873 9873
+ Misses 7988 7987 -1
Continue to review full report at Codecov.
|
Razican
approved these changes
Feb 21, 2022
Razican
requested review from
raskad,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2022
This Pull Request fixes/closes the incorrect message thrown for the following code: ```javascript "use strict"; foo = "bar"; ``` Which would throw the following before the change (incorrect): `Uncaught "ReferenceError": "binding already exists: foo"` And would throw the following after the change (correct): `Uncaught "ReferenceError": "assignment to undeclared variable foo"`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes the incorrect message thrown for the following code:
Which would throw the following before the change (incorrect):
Uncaught "ReferenceError": "binding already exists: foo"And would throw the following after the change (correct):
Uncaught "ReferenceError": "assignment to undeclared variable foo"