Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fixing main branch workflows #1858

Closed
wants to merge 1 commit into from
Closed

Conversation

Razican
Copy link
Member

@Razican Razican commented Feb 21, 2022

It seems that the workflow in the main branch is failing to push benchmark results, so I think this should fix it, let's see.

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. Internal Category for changelog labels Feb 21, 2022
@Razican Razican added this to the v0.14.0 milestone Feb 21, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 87,912 87,912 0
Passed 41,354 41,354 0
Ignored 21,153 21,153 0
Failed 25,405 25,405 0
Panics 12 12 0
Conformance 47.04% 47.04% 0.00%

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1858 (49d3eeb) into main (4d2772d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   56.09%   56.09%           
=======================================
  Files         200      200           
  Lines       17901    17901           
=======================================
  Hits        10042    10042           
  Misses       7859     7859           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2772d...49d3eeb. Read the comment docs.

@github-actions
Copy link

Benchmark for 7f97a22

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 435.1±0.69ns 449.0±2.45ns +3.19%
Arithmetic operations (Execution) 1914.6±3.70ns 1903.0±48.17ns -0.61%
Arithmetic operations (Parser) 5.7±0.01µs 5.7±0.01µs 0.00%
Array access (Compiler) 1283.9±2.17ns 1274.0±2.54ns -0.77%
Array access (Execution) 10.5±0.05µs 10.4±0.02µs -0.95%
Array access (Parser) 12.7±0.04µs 12.7±0.05µs 0.00%
Array creation (Compiler) 1908.2±3.62ns 1908.3±8.07ns +0.01%
Array creation (Execution) 3.1±0.02ms 3.1±0.00ms 0.00%
Array creation (Parser) 13.9±0.07µs 13.9±0.05µs 0.00%
Array pop (Compiler) 3.4±0.01µs 3.4±0.01µs 0.00%
Array pop (Execution) 1356.0±41.62µs 1347.6±3.22µs -0.62%
Array pop (Parser) 143.4±0.16µs 143.2±0.22µs -0.14%
Boolean Object Access (Compiler) 1055.2±2.35ns 1069.1±2.89ns +1.32%
Boolean Object Access (Execution) 5.9±0.07µs 5.7±0.07µs -3.39%
Boolean Object Access (Parser) 14.3±0.03µs 14.3±0.17µs 0.00%
Clean js (Compiler) 3.5±0.01µs 3.5±0.01µs 0.00%
Clean js (Execution) 1063.4±7.26µs 1067.2±4.72µs +0.36%
Clean js (Parser) 29.7±0.08µs 29.9±0.05µs +0.67%
Create Realm 253.2±2.19ns 258.5±2.32ns +2.09%
Dynamic Object Property Access (Compiler) 1676.0±4.97ns 1670.1±3.97ns -0.35%
Dynamic Object Property Access (Execution) 6.6±0.08µs 6.6±0.07µs 0.00%
Dynamic Object Property Access (Parser) 11.3±0.09µs 11.3±0.08µs 0.00%
Fibonacci (Compiler) 2.4±0.01µs 2.4±0.01µs 0.00%
Fibonacci (Execution) 1748.8±2.98µs 1775.3±6.42µs +1.52%
Fibonacci (Parser) 16.8±0.07µs 16.8±0.04µs 0.00%
For loop (Compiler) 2.1±0.00µs 2.0±0.00µs -4.76%
For loop (Execution) 41.0±0.18µs 41.3±0.18µs +0.73%
For loop (Parser) 14.6±0.04µs 14.5±0.05µs -0.68%
Mini js (Compiler) 3.4±0.01µs 3.4±0.04µs 0.00%
Mini js (Execution) 983.3±15.79µs 984.1±3.81µs +0.08%
Mini js (Parser) 26.1±0.08µs 26.1±0.08µs 0.00%
Number Object Access (Compiler) 967.2±1.81ns 976.5±1.88ns +0.96%
Number Object Access (Execution) 4.4±0.01µs 4.4±0.03µs 0.00%
Number Object Access (Parser) 11.2±0.05µs 11.2±0.07µs 0.00%
Object Creation (Compiler) 1364.9±5.10ns 1384.8±3.90ns +1.46%
Object Creation (Execution) 5.9±0.03µs 5.9±0.02µs 0.00%
Object Creation (Parser) 10.0±0.07µs 9.8±0.08µs -2.00%
RegExp (Compiler) 1616.5±2.87ns 1626.7±5.32ns +0.63%
RegExp (Execution) 12.1±0.05µs 12.0±0.05µs -0.83%
RegExp (Parser) 10.7±0.08µs 10.5±0.10µs -1.87%
RegExp Creation (Compiler) 1422.2±5.25ns 1378.1±4.50ns -3.10%
RegExp Creation (Execution) 9.0±0.03µs 9.2±0.04µs +2.22%
RegExp Creation (Parser) 8.9±0.10µs 8.7±0.07µs -2.25%
RegExp Literal (Compiler) 1575.6±2.64ns 1625.0±4.82ns +3.14%
RegExp Literal (Execution) 12.1±0.06µs 12.0±0.05µs -0.83%
RegExp Literal (Parser) 8.5±0.06µs 8.5±0.06µs 0.00%
RegExp Literal Creation (Compiler) 1410.6±5.26ns 1389.2±3.59ns -1.52%
RegExp Literal Creation (Execution) 9.0±0.03µs 9.0±0.02µs 0.00%
RegExp Literal Creation (Parser) 6.9±0.03µs 6.9±0.02µs 0.00%
Static Object Property Access (Compiler) 1396.5±5.68ns 1429.0±3.49ns +2.33%
Static Object Property Access (Execution) 6.1±0.05µs 6.2±0.07µs +1.64%
Static Object Property Access (Parser) 10.7±0.08µs 10.5±0.05µs -1.87%
String Object Access (Compiler) 1433.9±4.37ns 1428.9±6.30ns -0.35%
String Object Access (Execution) 7.8±0.08µs 7.5±0.07µs -3.85%
String Object Access (Parser) 14.1±0.03µs 14.1±0.06µs 0.00%
String comparison (Compiler) 2.1±0.01µs 2.1±0.01µs 0.00%
String comparison (Execution) 5.8±0.01µs 5.9±0.01µs +1.72%
String comparison (Parser) 11.5±0.07µs 11.4±0.06µs -0.87%
String concatenation (Compiler) 1617.7±5.44ns 1654.4±3.74ns +2.27%
String concatenation (Execution) 5.3±0.08µs 5.4±0.08µs +1.89%
String concatenation (Parser) 7.9±0.06µs 7.8±0.04µs -1.27%
String copy (Compiler) 1257.1±3.03ns 1280.1±2.25ns +1.83%
String copy (Execution) 4.7±0.01µs 4.7±0.01µs 0.00%
String copy (Parser) 5.9±0.05µs 6.0±0.06µs +1.69%
Symbols (Compiler) 839.6±1.82ns 858.3±2.47ns +2.23%
Symbols (Execution) 4.4±0.04µs 4.4±0.01µs 0.00%
Symbols (Parser) 4.6±0.30µs 4.5±0.07µs -2.17%

@raskad
Copy link
Member

raskad commented Feb 21, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 21, 2022
It seems that the workflow in the `main` branch is failing to push benchmark results, so I think this should fix it, let's see.
@bors
Copy link

bors bot commented Feb 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixing main branch workflows [Merged by Bors] - Fixing main branch workflows Feb 21, 2022
@bors bors bot closed this Feb 21, 2022
@bors bors bot deleted the fix_workflow branch February 21, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Internal Category for changelog test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants