[Merged by Bors] - Removed reference counted pointers from JsValue variants
#1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 46.65% 46.69% +0.03%
==========================================
Files 204 204
Lines 16706 16718 +12
==========================================
+ Hits 7795 7806 +11
- Misses 8911 8912 +1
Continue to review full report at Codecov.
|
|
Actually, I think this will reduce the performance when doing clones of |
Benchmark for f2ee903Click to view benchmark
|
Razican
commented
Feb 23, 2022
| @@ -554,7 +554,7 @@ impl<'b> ByteCompiler<'b> { | |||
| )), | |||
| Const::Int(v) => self.emit_push_integer(*v), | |||
| Const::Num(v) => self.emit_push_rational(*v), | |||
| Const::BigInt(v) => self.emit_push_literal(Literal::BigInt(v.clone())), | |||
| Const::BigInt(v) => self.emit_push_literal(Literal::BigInt(v.clone().into())), | |||
There was a problem hiding this comment.
This is the only place where I see that it will actually be less performant.
Benchmark for ea9fc25Click to view benchmark
|
Benchmark for 845144eClick to view benchmark
|
|
Wow performance seems pretty bad |
I'm curious if the cause was moving the internal |
I don't see how this could have an impact. From the unsafe code guide: Other than the layout is there anything that could be affected by the struct definition? |
Nope, that structure should be exactly the same. But the issue is that calling Something I also noticed is that we clone tokens too much. We should have a |
Benchmark for 16437d8Click to view benchmark
|
It also modifies the `JsObject` variant so that it has a similar structure to other variants, where the internal structure is private.
Benchmark for e6ea8bdClick to view benchmark
|
raskad
approved these changes
Feb 27, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2022
This Pull Request fixes/closes #1864. It changes the following: - Removed `JsBigInt` from `Const` nodes, using a boxed `BigInt` instead. - Modifies the `JsObject` variant so that it has a similar structure to other variants, where the internal structure is private. The size of `JsValue` stays in 2 64-bit words (in a 64-bit system at least), and the size of `Const` also stays the same. I have noticed that we clone tokens too much in the parser, so I was thinking that we should implement a by-value getter for `kind()`. Something like `kind_unwrap()`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
JsValue variantsJsValue variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1864.
It changes the following:
JsBigIntfromConstnodes, using a boxedBigIntinstead.JsObjectvariant so that it has a similar structure to other variants, where the internal structure is private.The size of
JsValuestays in 2 64-bit words (in a 64-bit system at least), and the size ofConstalso stays the same.I have noticed that we clone tokens too much in the parser, so I was thinking that we should implement a by-value getter for
kind(). Something likekind_unwrap().