-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix BigInt
and Number
comparison
#1887
Conversation
Test262 conformance changesVM implementation
Fixed tests (8):
|
Hmmm... There are some broken tests. I will make this draft till I fix them. |
Codecov Report
@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 45.86% 45.88% +0.01%
==========================================
Files 206 206
Lines 17097 17101 +4
==========================================
+ Hits 7842 7846 +4
Misses 9255 9255
Continue to review full report at Codecov.
|
Benchmark for 7fc7d49Click to view benchmark
|
@HalidOdat do you think this could be ready during the weekend, or should we move it to 0.15? |
I will try to fix this during this weekend :) |
c05d8ef
to
ebd7fd9
Compare
ebd7fd9
to
65219f7
Compare
Benchmark for 4687c0bClick to view benchmark
|
Benchmark for e0e0b54Click to view benchmark
|
Benchmark for aab909bClick to view benchmark
|
bors r+ |
Pull request successfully merged into main. Build succeeded: |
BigInt
and Number
comparisonBigInt
and Number
comparison
Fixes
BigInt
andNumber
comparison, and vice versa. Before we were removing the decimal point of the floating-point number which was causing cases like0.000001 > 0n
(or0n < 0.000001
) to fail.