[Merged by Bors] - Added better error handling for the Boa tester #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1984 +/- ##
=======================================
Coverage 45.93% 45.93%
=======================================
Files 206 206
Lines 17138 17138
=======================================
Hits 7873 7873
Misses 9265 9265
Continue to review full report at Codecov.
|
Benchmark for d345ee6Click to view benchmark
|
raskad
approved these changes
Mar 28, 2022
jedel1043
approved these changes
Mar 28, 2022
HalidOdat
approved these changes
Mar 29, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Trying to fix the issue in #1982, I noticed that we didn't have a proper error handling for the boa tester. This adds the `anyhow` dependency to the tester, which makes it much easier to handle errors and bubble them up with attached context. Thanks to this I was able to easily find out the issue, and I think it could be useful to have it. It gives errors such as this one: ``` Error: could not read the suite test caused by: error reading sub-suite ./test262/test/built-ins caused by: error reading sub-suite ./test262/test/built-ins/ShadowRealm caused by: error reading sub-suite ./test262/test/built-ins/ShadowRealm/WrappedFunction caused by: error reading test ./test262/test/built-ins/ShadowRealm/WrappedFunction/throws-typeerror-on-revoked-proxy.js caused by: while scanning a block scalar, found a tab character where an indentation space is expected at line 4 column 3 caused by: while scanning a block scalar, found a tab character where an indentation space is expected at line 4 column 3 ```
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
added a commit
that referenced
this pull request
Jun 8, 2022
Trying to fix the issue in #1982, I noticed that we didn't have a proper error handling for the boa tester. This adds the `anyhow` dependency to the tester, which makes it much easier to handle errors and bubble them up with attached context. Thanks to this I was able to easily find out the issue, and I think it could be useful to have it. It gives errors such as this one: ``` Error: could not read the suite test caused by: error reading sub-suite ./test262/test/built-ins caused by: error reading sub-suite ./test262/test/built-ins/ShadowRealm caused by: error reading sub-suite ./test262/test/built-ins/ShadowRealm/WrappedFunction caused by: error reading test ./test262/test/built-ins/ShadowRealm/WrappedFunction/throws-typeerror-on-revoked-proxy.js caused by: while scanning a block scalar, found a tab character where an indentation space is expected at line 4 column 3 caused by: while scanning a block scalar, found a tab character where an indentation space is expected at line 4 column 3 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the issue in #1982, I noticed that we didn't have a proper error handling for the boa tester.
This adds the
anyhowdependency to the tester, which makes it much easier to handle errors and bubble them up with attached context. Thanks to this I was able to easily find out the issue, and I think it could be useful to have it. It gives errors such as this one: