Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove git2 and hex dependencies #1992

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 31, 2022

This removes the only use of the git2 and hex dependencies by reading the test262 submodule commit id directly from the .git directory.

Because git2 depends on a lot of other crates, this removes a bunch of dependencies.

@raskad raskad added the Internal Category for changelog label Mar 31, 2022
@raskad raskad added this to the v0.15.0 milestone Mar 31, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,428 88,428 0
Passed 44,003 44,003 0
Ignored 21,495 21,495 0
Failed 22,930 22,930 0
Panics 0 0 0
Conformance 49.76% 49.76% 0.00%

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1992 (49c4804) into main (c23d32b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files         206      206           
  Lines       17148    17148           
=======================================
+ Hits         7871     7872    +1     
+ Misses       9277     9276    -1     
Impacted Files Coverage Δ
...parser/expression/primary/array_initializer/mod.rs 53.57% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23d32b...49c4804. Read the comment docs.

@github-actions
Copy link

Benchmark for dda129f

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 606.8±1.95ns 609.2±1.98ns +0.40%
Arithmetic operations (Execution) 810.9±0.99ns 822.4±0.59ns +1.42%
Arithmetic operations (Parser) 5.7±0.01µs 5.7±0.01µs 0.00%
Array access (Compiler) 1532.7±3.84ns 1523.7±7.93ns -0.59%
Array access (Execution) 8.7±0.03µs 8.8±0.04µs +1.15%
Array access (Parser) 12.7±0.02µs 12.7±0.02µs 0.00%
Array creation (Compiler) 2.2±0.02µs 2.1±0.01µs -4.55%
Array creation (Execution) 2.9±0.00ms 2.9±0.01ms 0.00%
Array creation (Parser) 14.5±0.02µs 14.5±0.11µs 0.00%
Array pop (Compiler) 4.6±0.02µs 4.6±0.04µs 0.00%
Array pop (Execution) 1276.1±6.38µs 1277.4±6.84µs +0.10%
Array pop (Parser) 148.7±0.76µs 148.7±0.15µs 0.00%
Boolean Object Access (Compiler) 1192.2±11.06ns 1216.1±3.71ns +2.00%
Boolean Object Access (Execution) 4.7±0.01µs 4.7±0.01µs 0.00%
Boolean Object Access (Parser) 15.8±0.02µs 15.8±0.02µs 0.00%
Clean js (Compiler) 4.0±0.01µs 4.0±0.01µs 0.00%
Clean js (Execution) 813.4±4.55µs 815.8±5.52µs +0.30%
Clean js (Parser) 31.1±0.07µs 31.1±0.05µs 0.00%
Create Realm 326.8±3.92ns 327.0±0.44ns +0.06%
Dynamic Object Property Access (Compiler) 1912.7±4.23ns 1921.9±5.11ns +0.48%
Dynamic Object Property Access (Execution) 5.9±0.02µs 5.9±0.02µs 0.00%
Dynamic Object Property Access (Parser) 11.2±0.02µs 11.2±0.02µs 0.00%
Fibonacci (Compiler) 2.7±0.01µs 2.7±0.01µs 0.00%
Fibonacci (Execution) 1505.2±3.56µs 1521.0±15.31µs +1.05%
Fibonacci (Parser) 17.6±0.02µs 17.6±0.02µs 0.00%
For loop (Compiler) 2.3±0.01µs 2.3±0.01µs 0.00%
For loop (Execution) 17.8±0.06µs 17.7±0.05µs -0.56%
For loop (Parser) 14.9±0.03µs 14.9±0.02µs 0.00%
Mini js (Compiler) 3.9±0.01µs 3.9±0.01µs 0.00%
Mini js (Execution) 773.2±6.92µs 772.0±5.05µs -0.16%
Mini js (Parser) 27.0±0.06µs 27.0±0.03µs 0.00%
Number Object Access (Compiler) 1124.3±4.40ns 1130.9±2.43ns +0.59%
Number Object Access (Execution) 3.6±0.01µs 3.6±0.01µs 0.00%
Number Object Access (Parser) 12.0±0.03µs 12.0±0.02µs 0.00%
Object Creation (Compiler) 1642.2±7.68ns 1672.9±7.66ns +1.87%
Object Creation (Execution) 5.7±0.02µs 5.7±0.01µs 0.00%
Object Creation (Parser) 9.9±0.02µs 9.9±0.05µs 0.00%
RegExp (Compiler) 1948.3±4.69ns 1943.1±4.43ns -0.27%
RegExp (Execution) 13.1±0.09µs 13.1±0.09µs 0.00%
RegExp (Parser) 10.9±0.02µs 10.9±0.02µs 0.00%
RegExp Creation (Compiler) 1690.0±8.09ns 1674.7±7.38ns -0.91%
RegExp Creation (Execution) 9.9±0.03µs 9.9±0.03µs 0.00%
RegExp Creation (Parser) 9.2±0.02µs 9.2±0.02µs 0.00%
RegExp Literal (Compiler) 1964.5±3.66ns 1956.5±4.81ns -0.41%
RegExp Literal (Execution) 13.2±0.13µs 13.2±0.10µs 0.00%
RegExp Literal (Parser) 8.8±0.01µs 8.7±0.02µs -1.14%
RegExp Literal Creation (Compiler) 1667.8±8.44ns 1688.4±16.35ns +1.24%
RegExp Literal Creation (Execution) 10.0±0.04µs 9.9±0.07µs -1.00%
RegExp Literal Creation (Parser) 6.9±0.02µs 7.0±0.01µs +1.45%
Static Object Property Access (Compiler) 1699.6±8.54ns 1707.4±8.26ns +0.46%
Static Object Property Access (Execution) 5.8±0.23µs 5.8±0.01µs 0.00%
Static Object Property Access (Parser) 10.6±0.02µs 10.6±0.04µs 0.00%
String Object Access (Compiler) 1625.6±7.22ns 1629.8±10.06ns +0.26%
String Object Access (Execution) 6.8±0.02µs 6.8±0.02µs 0.00%
String Object Access (Parser) 15.3±0.02µs 15.4±0.07µs +0.65%
String comparison (Compiler) 2.5±0.01µs 2.5±0.01µs 0.00%
String comparison (Execution) 5.1±0.02µs 5.1±0.02µs 0.00%
String comparison (Parser) 11.9±0.06µs 11.9±0.02µs 0.00%
String concatenation (Compiler) 1949.0±3.84ns 1999.8±2.67ns +2.61%
String concatenation (Execution) 4.8±0.03µs 4.8±0.03µs 0.00%
String concatenation (Parser) 8.0±0.01µs 8.1±0.04µs +1.25%
String copy (Compiler) 1554.9±3.71ns 1573.5±3.20ns +1.20%
String copy (Execution) 4.5±0.01µs 4.5±0.01µs 0.00%
String copy (Parser) 5.9±0.01µs 6.0±0.02µs +1.69%
Symbols (Compiler) 1120.1±2.55ns 1095.4±2.84ns -2.21%
Symbols (Execution) 4.6±0.01µs 4.6±0.01µs 0.00%
Symbols (Parser) 4.5±0.01µs 4.6±0.01µs +2.22%

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 31, 2022
This removes the only use of the `git2` and `hex` dependencies by reading the test262 submodule commit id directly from the `.git` directory.

Because `git2` depends on a lot of other crates, this removes a bunch of dependencies.
@bors
Copy link

bors bot commented Mar 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove git2 and hex dependencies [Merged by Bors] - Remove git2 and hex dependencies Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@bors bors bot deleted the remove-git-dependency branch March 31, 2022 14:12
Razican added a commit that referenced this pull request Jun 8, 2022
This removes the only use of the `git2` and `hex` dependencies by reading the test262 submodule commit id directly from the `.git` directory.

Because `git2` depends on a lot of other crates, this removes a bunch of dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants