Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix rust 1.60 clippy lints #2014

Closed
wants to merge 1 commit into from
Closed

Conversation

raskad
Copy link
Member

@raskad raskad commented Apr 7, 2022

This Pull Request fixes new / improved clippy lints with rust 1.60.

@raskad raskad added the Internal Category for changelog label Apr 7, 2022
@raskad raskad added this to the v0.15.0 milestone Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,650 88,650 0
Passed 50,746 50,746 0
Ignored 21,711 21,711 0
Failed 16,193 16,193 0
Panics 0 0 0
Conformance 57.24% 57.24% 0.00%

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2014 (bfc27e7) into main (2239669) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
+ Coverage   43.86%   43.99%   +0.12%     
==========================================
  Files         211      211              
  Lines       18667    18665       -2     
==========================================
+ Hits         8189     8211      +22     
+ Misses      10478    10454      -24     
Impacted Files Coverage Δ
boa_engine/src/builtins/array_buffer/mod.rs 9.44% <ø> (ø)
boa_engine/src/value/display.rs 80.00% <ø> (ø)
boa_engine/src/builtins/regexp/mod.rs 67.63% <100.00%> (ø)
boa_engine/src/syntax/ast/punctuator.rs 11.11% <0.00%> (-22.23%) ⬇️
boa_engine/src/syntax/ast/node/spread/mod.rs 57.14% <0.00%> (-14.29%) ⬇️
boa_engine/src/syntax/ast/position.rs 20.00% <0.00%> (-12.00%) ⬇️
boa_engine/src/syntax/lexer/cursor.rs 51.94% <0.00%> (-6.32%) ⬇️
boa_engine/src/syntax/lexer/template.rs 34.78% <0.00%> (-4.35%) ⬇️
...parser/expression/primary/array_initializer/mod.rs 50.00% <0.00%> (-3.58%) ⬇️
boa_engine/src/syntax/ast/node/template/mod.rs 51.72% <0.00%> (-3.45%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2239669...bfc27e7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Benchmark for c4e2aac

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 644.6±1.84ns 640.5±2.07ns -0.64%
Arithmetic operations (Execution) 808.5±1.19ns 807.7±1.04ns -0.10%
Arithmetic operations (Parser) 6.7±0.01µs 6.7±0.00µs 0.00%
Array access (Compiler) 1594.5±3.59ns 1577.4±3.25ns -1.07%
Array access (Execution) 9.6±0.06µs 9.7±0.03µs +1.04%
Array access (Parser) 14.5±0.03µs 14.4±0.04µs -0.69%
Array creation (Compiler) 2.2±0.01µs 2.2±0.01µs 0.00%
Array creation (Execution) 3.2±0.00ms 3.2±0.00ms 0.00%
Array creation (Parser) 16.6±0.03µs 16.7±0.02µs +0.60%
Array pop (Compiler) 4.8±0.02µs 4.5±0.01µs -6.25%
Array pop (Execution) 1413.2±3.34µs 1409.6±3.34µs -0.25%
Array pop (Parser) 169.7±0.25µs 169.9±0.13µs +0.12%
Boolean Object Access (Compiler) 1189.9±4.15ns 1157.2±6.34ns -2.75%
Boolean Object Access (Execution) 5.1±0.02µs 5.1±0.01µs 0.00%
Boolean Object Access (Parser) 17.6±0.01µs 17.7±0.06µs +0.57%
Clean js (Compiler) 4.1±0.01µs 4.0±0.01µs -2.44%
Clean js (Execution) 850.1±5.22µs 862.9±4.83µs +1.51%
Clean js (Parser) 35.6±0.06µs 36.1±0.05µs +1.40%
Create Realm 358.5±0.31ns 337.7±1.55ns -5.80%
Dynamic Object Property Access (Compiler) 1993.8±7.09ns 2.0±0.01µs +0.31%
Dynamic Object Property Access (Execution) 6.6±0.05µs 6.7±0.03µs +1.52%
Dynamic Object Property Access (Parser) 12.9±0.01µs 12.8±0.03µs -0.78%
Fibonacci (Compiler) 2.9±0.01µs 2.8±0.02µs -3.45%
Fibonacci (Execution) 1628.0±2.40µs 1668.5±1.72µs +2.49%
Fibonacci (Parser) 19.9±0.03µs 20.0±0.03µs +0.50%
For loop (Compiler) 2.5±0.01µs 2.5±0.02µs 0.00%
For loop (Execution) 18.8±0.04µs 19.0±0.04µs +1.06%
For loop (Parser) 17.2±0.02µs 17.0±0.03µs -1.16%
Mini js (Compiler) 4.0±0.01µs 3.9±0.01µs -2.50%
Mini js (Execution) 808.2±9.08µs 817.1±4.63µs +1.10%
Mini js (Parser) 31.5±0.03µs 31.7±0.03µs +0.63%
Number Object Access (Compiler) 1161.4±4.82ns 1142.2±8.38ns -1.65%
Number Object Access (Execution) 4.0±0.02µs 4.0±0.02µs 0.00%
Number Object Access (Parser) 13.6±0.01µs 13.7±0.02µs +0.74%
Object Creation (Compiler) 1742.7±7.65ns 1724.1±5.00ns -1.07%
Object Creation (Execution) 6.2±0.02µs 6.4±0.04µs +3.23%
Object Creation (Parser) 11.2±0.01µs 11.2±0.05µs 0.00%
RegExp (Compiler) 2.0±0.02µs 2.0±0.01µs 0.00%
RegExp (Execution) 14.2±0.05µs 13.6±0.04µs -4.23%
RegExp (Parser) 12.3±0.01µs 12.2±0.03µs -0.81%
RegExp Creation (Compiler) 1766.7±6.89ns 1763.2±7.81ns -0.20%
RegExp Creation (Execution) 10.8±0.03µs 10.2±0.04µs -5.56%
RegExp Creation (Parser) 10.2±0.02µs 10.2±0.01µs 0.00%
RegExp Literal (Compiler) 2.1±0.01µs 2.0±0.01µs -4.76%
RegExp Literal (Execution) 14.2±0.04µs 13.6±0.18µs -4.23%
RegExp Literal (Parser) 10.0±0.01µs 9.9±0.01µs -1.00%
RegExp Literal Creation (Compiler) 1752.0±4.45ns 1797.4±7.16ns +2.59%
RegExp Literal Creation (Execution) 10.8±0.03µs 10.2±0.04µs -5.56%
RegExp Literal Creation (Parser) 7.8±0.01µs 7.8±0.09µs 0.00%
Static Object Property Access (Compiler) 1790.9±5.34ns 1728.1±5.30ns -3.51%
Static Object Property Access (Execution) 6.4±0.03µs 6.6±0.04µs +3.12%
Static Object Property Access (Parser) 12.0±0.02µs 12.0±0.29µs 0.00%
String Object Access (Compiler) 1641.4±5.94ns 1636.2±15.54ns -0.32%
String Object Access (Execution) 7.2±0.02µs 7.3±0.02µs +1.39%
String Object Access (Parser) 17.4±0.02µs 17.5±0.01µs +0.57%
String comparison (Compiler) 2.6±0.01µs 2.6±0.01µs 0.00%
String comparison (Execution) 5.6±0.02µs 5.7±0.02µs +1.79%
String comparison (Parser) 13.7±0.02µs 13.7±0.02µs 0.00%
String concatenation (Compiler) 2.1±0.00µs 2.0±0.00µs -4.76%
String concatenation (Execution) 5.4±0.02µs 5.4±0.02µs 0.00%
String concatenation (Parser) 9.2±0.04µs 9.2±0.03µs 0.00%
String copy (Compiler) 1645.5±3.57ns 1596.1±3.58ns -3.00%
String copy (Execution) 5.1±0.03µs 5.1±0.02µs 0.00%
String copy (Parser) 6.7±0.02µs 6.8±0.05µs +1.49%
Symbols (Compiler) 1164.7±6.28ns 1143.2±4.24ns -1.85%
Symbols (Execution) 5.2±0.02µs 5.2±0.01µs 0.00%
Symbols (Parser) 5.1±0.00µs 5.1±0.00µs 0.00%

@RageKnify
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 8, 2022
This Pull Request fixes new / improved clippy lints with rust 1.60.
@bors
Copy link

bors bot commented Apr 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix rust 1.60 clippy lints [Merged by Bors] - Fix rust 1.60 clippy lints Apr 8, 2022
@bors bors bot closed this Apr 8, 2022
@bors bors bot deleted the clippy-lints branch April 8, 2022 10:48
Razican pushed a commit that referenced this pull request Jun 8, 2022
This Pull Request fixes new / improved clippy lints with rust 1.60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants