Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix for in/of loop initializer environment #2135

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 20, 2022

This Pull Request changes the following:

  • Add an additional environment when a for in/of loop is initialized with a let or const binding.

@raskad raskad added enhancement New feature or request execution Issues or PRs related to code execution labels Jun 20, 2022
@raskad raskad added this to the v0.16.0 milestone Jun 20, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,619 90,619 0
Passed 56,877 56,885 +8
Ignored 13,788 13,788 0
Failed 19,954 19,946 -8
Panics 0 0 0
Conformance 62.76% 62.77% +0.01%
Fixed tests (8):
test/language/statements/for-of/head-let-bound-names-fordecl-tdz.js [strict mode] (previously Failed)
test/language/statements/for-of/head-let-bound-names-fordecl-tdz.js (previously Failed)
test/language/statements/for-of/head-const-bound-names-fordecl-tdz.js [strict mode] (previously Failed)
test/language/statements/for-of/head-const-bound-names-fordecl-tdz.js (previously Failed)
test/language/statements/for-in/head-let-bound-names-fordecl-tdz.js [strict mode] (previously Failed)
test/language/statements/for-in/head-let-bound-names-fordecl-tdz.js (previously Failed)
test/language/statements/for-in/head-const-bound-names-fordecl-tdz.js [strict mode] (previously Failed)
test/language/statements/for-in/head-const-bound-names-fordecl-tdz.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #2135 (23ea855) into main (91b28ec) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2135      +/-   ##
==========================================
+ Coverage   43.48%   43.51%   +0.03%     
==========================================
  Files         220      220              
  Lines       19984    20015      +31     
==========================================
+ Hits         8690     8710      +20     
- Misses      11294    11305      +11     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler.rs 32.36% <75.00%> (+0.65%) ⬆️
boa_engine/src/environments/runtime.rs 23.71% <0.00%> (-1.04%) ⬇️
boa_engine/src/context/mod.rs 32.17% <0.00%> (-0.44%) ⬇️
boa_engine/src/builtins/mod.rs 10.76% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b28ec...23ea855. Read the comment docs.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 21, 2022
This Pull Request changes the following:

- Add an additional environment when a for in/of loop is initialized with a `let` or `const` binding.
@bors
Copy link

bors bot commented Jun 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix for in/of loop initializer environment [Merged by Bors] - Fix for in/of loop initializer environment Jun 21, 2022
@bors bors bot closed this Jun 21, 2022
@bors bors bot deleted the fix-loop-initializer-environment branch June 21, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants