Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement Promise.any #2145

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement Promise.any #2145

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 27, 2022

This Pull Request changes the following:

  • Implement Promise.any

@raskad raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jun 27, 2022
@raskad raskad added this to the v0.16.0 milestone Jun 27, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,663 90,663 0
Passed 57,366 57,516 +150
Ignored 13,832 13,832 0
Failed 19,465 19,315 -150
Panics 0 0 0
Conformance 63.27% 63.44% +0.17%
Fixed tests (150):
test/built-ins/Promise/any/capability-executor-not-callable.js [strict mode] (previously Failed)
test/built-ins/Promise/any/capability-executor-not-callable.js (previously Failed)
test/built-ins/Promise/any/iter-next-val-err-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-next-val-err-no-close.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-string-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-string-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve.js (previously Failed)
test/built-ins/Promise/any/invoke-then-get-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then-get-error-reject.js (previously Failed)
test/built-ins/Promise/any/name.js [strict mode] (previously Failed)
test/built-ins/Promise/any/name.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-symbol-reject.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-true-reject.js (previously Failed)
test/built-ins/Promise/any/ctx-non-ctor.js [strict mode] (previously Failed)
test/built-ins/Promise/any/ctx-non-ctor.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-on-values-every-iteration-of-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-on-values-every-iteration-of-promise.js (previously Failed)
test/built-ins/Promise/any/ctx-ctor-throws.js [strict mode] (previously Failed)
test/built-ins/Promise/any/ctx-ctor-throws.js (previously Failed)
test/built-ins/Promise/any/resolve-ignores-late-rejection-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-ignores-late-rejection-deferred.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-number-reject.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-false-reject.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-number-reject.js (previously Failed)
test/built-ins/Promise/any/iter-step-err-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-step-err-reject.js (previously Failed)
test/built-ins/Promise/any/resolve-ignores-late-rejection.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-ignores-late-rejection.js (previously Failed)
test/built-ins/Promise/any/reject-immed.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-immed.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-true-reject.js (previously Failed)
test/built-ins/Promise/any/capability-resolve-throws-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/capability-resolve-throws-no-close.js (previously Failed)
test/built-ins/Promise/any/iter-returns-string-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-string-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-get-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-get-error-reject.js (previously Failed)
test/built-ins/Promise/any/resolve-from-reject-catch.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-from-reject-catch.js (previously Failed)
test/built-ins/Promise/any/reject-from-same-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-from-same-thenable.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-string-resolve.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-string-resolve.js (previously Failed)
test/built-ins/Promise/any/resolved-sequence-mixed.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolved-sequence-mixed.js (previously Failed)
test/built-ins/Promise/any/iter-returns-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-undefined-reject.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-length.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-length.js (previously Failed)
test/built-ins/Promise/any/reject-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-deferred.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-name.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-name.js (previously Failed)
test/built-ins/Promise/any/invoke-then.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then.js (previously Failed)
test/built-ins/Promise/any/reject-ignored-immed.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-ignored-immed.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-on-promises-every-iteration-of-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-on-promises-every-iteration-of-promise.js (previously Failed)
test/built-ins/Promise/any/iter-returns-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-false-reject.js (previously Failed)
test/built-ins/Promise/any/iter-step-err-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-step-err-no-close.js (previously Failed)
test/built-ins/Promise/any/species-get-error.js [strict mode] (previously Failed)
test/built-ins/Promise/any/species-get-error.js (previously Failed)
test/built-ins/Promise/any/resolved-sequence-extra-ticks.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolved-sequence-extra-ticks.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-poisoned.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-poisoned.js (previously Failed)
test/built-ins/Promise/any/resolve-from-resolve-reject-catch.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-from-resolve-reject-catch.js (previously Failed)
test/built-ins/Promise/any/iter-returns-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-null-reject.js (previously Failed)
test/built-ins/Promise/any/resolve-from-same-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-from-same-thenable.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-false-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-return.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-return.js (previously Failed)
test/built-ins/Promise/any/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Promise/any/prop-desc.js (previously Failed)
test/built-ins/Promise/any/iter-returns-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-true-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-then-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then-error-close.js (previously Failed)
test/built-ins/Promise/any/invoke-then-get-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then-get-error-close.js (previously Failed)
test/built-ins/Promise/any/invoke-then-on-promises-every-iteration.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then-on-promises-every-iteration.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-undefined-reject.js (previously Failed)
test/built-ins/Promise/any/iter-next-val-err-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-next-val-err-reject.js (previously Failed)
test/built-ins/Promise/any/iter-returns-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-symbol-reject.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-error-object-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-error-object-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-get-error.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-get-error.js (previously Failed)
test/built-ins/Promise/any/resolve-non-callable.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-non-callable.js (previously Failed)
test/built-ins/Promise/any/resolved-sequence.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolved-sequence.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-nonconstructor.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-nonconstructor.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-undefined-reject.js (previously Failed)
test/built-ins/Promise/any/capability-executor-called-twice.js [strict mode] (previously Failed)
test/built-ins/Promise/any/capability-executor-called-twice.js (previously Failed)
test/built-ins/Promise/any/length.js [strict mode] (previously Failed)
test/built-ins/Promise/any/length.js (previously Failed)
test/built-ins/Promise/any/capability-resolve-throws-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/capability-resolve-throws-reject.js (previously Failed)
test/built-ins/Promise/any/is-function.js [strict mode] (previously Failed)
test/built-ins/Promise/any/is-function.js (previously Failed)
test/built-ins/Promise/any/resolve-non-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-non-thenable.js (previously Failed)
test/built-ins/Promise/any/new-reject-function.js [strict mode] (previously Failed)
test/built-ins/Promise/any/new-reject-function.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-null-reject.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-error-close.js (previously Failed)
test/built-ins/Promise/any/invoke-resolve-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-resolve-error-reject.js (previously Failed)
test/built-ins/Promise/any/returns-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/any/returns-promise.js (previously Failed)
test/built-ins/Promise/any/capability-reject-throws-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/any/capability-reject-throws-no-close.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-prototype.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-prototype.js (previously Failed)
test/built-ins/Promise/any/iter-arg-is-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-arg-is-symbol-reject.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-property-order.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-property-order.js (previously Failed)
test/built-ins/Promise/any/reject-element-function-extensible.js [strict mode] (previously Failed)
test/built-ins/Promise/any/reject-element-function-extensible.js (previously Failed)
test/built-ins/Promise/any/invoke-then-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/invoke-then-error-reject.js (previously Failed)
test/built-ins/Promise/any/iter-assigned-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-assigned-null-reject.js (previously Failed)
test/built-ins/Promise/any/iter-returns-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/any/iter-returns-number-reject.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #2145 (8876b22) into main (ce8c6e2) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   43.40%   43.28%   -0.12%     
==========================================
  Files         220      220              
  Lines       20079    20134      +55     
==========================================
  Hits         8715     8715              
- Misses      11364    11419      +55     
Impacted Files Coverage Δ
boa_engine/src/builtins/promise/mod.rs 23.64% <0.00%> (-5.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8c6e2...8876b22. Read the comment docs.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@raskad
Copy link
Member Author

raskad commented Jun 27, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 27, 2022
This Pull Request changes the following:

- Implement `Promise.any`
@bors
Copy link

bors bot commented Jun 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement Promise.any [Merged by Bors] - Implement Promise.any Jun 27, 2022
@bors bors bot closed this Jun 27, 2022
@bors bors bot deleted the promise-any branch June 27, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants