Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix remaining Promise bugs #2156

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix remaining Promise bugs #2156

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jul 1, 2022

This Pull Request changes the following:

  • Fix Promise.then length to 2.
  • Fix all, allSettled and any element lists to actually be shared between closures.
  • Fix allSettled reject element function to call resolve instead of reject.

The remaining failing tests for Promise fail because of some errors in the arrow function parsing.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jul 1, 2022
@raskad raskad added this to the v0.16.0 milestone Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,663 90,663 0
Passed 58,313 58,387 +74
Ignored 13,832 13,832 0
Failed 18,518 18,444 -74
Panics 0 0 0
Conformance 64.32% 64.40% +0.08%
Fixed tests (74): 
test/built-ins/Promise/any/resolve-before-loop-exit-from-same.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-before-loop-exit-from-same.js (previously Failed)
test/built-ins/Promise/any/resolved-sequence-with-rejections.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolved-sequence-with-rejections.js (previously Failed)
test/built-ins/Promise/any/call-reject-element-after-return.js [strict mode] (previously Failed)
test/built-ins/Promise/any/call-reject-element-after-return.js (previously Failed)
test/built-ins/Promise/any/call-reject-element-items.js [strict mode] (previously Failed)
test/built-ins/Promise/any/call-reject-element-items.js (previously Failed)
test/built-ins/Promise/any/resolve-before-loop-exit.js [strict mode] (previously Failed)
test/built-ins/Promise/any/resolve-before-loop-exit.js (previously Failed)
test/built-ins/Promise/all/resolve-ignores-late-rejection-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-ignores-late-rejection-deferred.js (previously Failed)
test/built-ins/Promise/all/resolve-ignores-late-rejection.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-ignores-late-rejection.js (previously Failed)
test/built-ins/Promise/all/call-resolve-element-items.js [strict mode] (previously Failed)
test/built-ins/Promise/all/call-resolve-element-items.js (previously Failed)
test/built-ins/Promise/all/resolve-before-loop-exit-from-same.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-before-loop-exit-from-same.js (previously Failed)
test/built-ins/Promise/all/call-resolve-element-after-return.js [strict mode] (previously Failed)
test/built-ins/Promise/all/call-resolve-element-after-return.js (previously Failed)
test/built-ins/Promise/all/resolve-from-same-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-from-same-thenable.js (previously Failed)
test/built-ins/Promise/all/resolve-non-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-non-thenable.js (previously Failed)
test/built-ins/Promise/all/resolve-before-loop-exit.js [strict mode] (previously Failed)
test/built-ins/Promise/all/resolve-before-loop-exit.js (previously Failed)
test/built-ins/Promise/all/call-resolve-element.js [strict mode] (previously Failed)
test/built-ins/Promise/all/call-resolve-element.js (previously Failed)
test/built-ins/Promise/race/resolved-sequence-with-rejections.js [strict mode] (previously Failed)
test/built-ins/Promise/race/resolved-sequence-with-rejections.js (previously Failed)
test/built-ins/Promise/race/resolved-sequence.js [strict mode] (previously Failed)
test/built-ins/Promise/race/resolved-sequence.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-ignores-late-rejection-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-ignores-late-rejection-deferred.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-then-catch-finally.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-then-catch-finally.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-ignores-late-rejection.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-ignores-late-rejection.js (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element-items.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element-items.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-before-loop-exit-from-same.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-before-loop-exit-from-same.js (previously Failed)
test/built-ins/Promise/allSettled/reject-immed.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-immed.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-rejected.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-rejected.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-with-rejections.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-with-rejections.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-mixed.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-mixed.js (previously Failed)
test/built-ins/Promise/allSettled/reject-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-deferred.js (previously Failed)
test/built-ins/Promise/allSettled/reject-ignored-immed.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-ignored-immed.js (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element-after-return.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element-after-return.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-from-same-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-from-same-thenable.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-fulfilled.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-fulfilled.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-non-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-non-thenable.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-before-loop-exit.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-before-loop-exit.js (previously Failed)
test/built-ins/Promise/allSettled/reject-ignored-deferred.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-ignored-deferred.js (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/call-resolve-element.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-mixed.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-all-mixed.js (previously Failed)
test/built-ins/Promise/prototype/then/length.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/length.js (previously Failed)
test/built-ins/Promise/prototype/then/S25.4.5.3_A1.1_T2.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/S25.4.5.3_A1.1_T2.js (previously Failed)

Razican
Razican approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@codecov
Copy link

codecov bot commented Jul 1, 2022 •
edited
Loading

Codecov Report

Merging #2156 (843131a) into main (4a8bf02) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
- Coverage   42.70%   42.70%   -0.01%     
==========================================
  Files         225      225              
  Lines       20790    20793       +3     
==========================================
+ Hits         8878     8879       +1     
- Misses      11912    11914       +2
Impacted Files Coverage Δ
boa_engine/src/builtins/promise/mod.rs 19.22% <0.00%> (-0.16%) ⬇️
...a_engine/src/syntax/ast/node/statement_list/mod.rs 81.25% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8bf02...843131a. Read the comment docs.

jedel1043
jedel1043 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 1, 2022
@raskad
Fix remaining Promise bugs (#2156)
bd0bf78 
This Pull Request changes the following:

- Fix `Promise.then` length to 2.
- Fix `all`, `allSettled` and `any` element lists to actually be shared between closures.
- Fix `allSettled` reject element function to call resolve instead of reject.

The remaining failing tests for `Promise` fail because of some errors in the arrow function parsing.
@bors
Copy link

bors bot commented Jul 1, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix remaining Promise bugs [Merged by Bors] - Fix remaining Promise bugs Jul 1, 2022
@bors bors bot closed this Jul 1, 2022
@bors bors bot deleted the fix-promise branch July 1, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @Razican