[Merged by Bors] - Implement JsArrayBuffer
#2170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad and
jedel1043
- Added example `jsarraybuffer.rs`
HalidOdat
force-pushed
the
feature/jsarraybuffers
branch
from
208751a
to
0f88f7b
Compare
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2170 +/- ##
==========================================
- Coverage 42.28% 42.19% -0.10%
==========================================
Files 228 229 +1
Lines 21167 21206 +39
==========================================
- Hits 8951 8948 -3
- Misses 12216 12258 +42
Continue to review full report at Codecov.
|
16 tasks
raskad
approved these changes
Jul 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
This PR adds the `ArrayBuffer` rust wrapper. It also provides a capability to construct a `JsArrayBuffer` from a user defined blob of data ( `Vec<u8>` ) and it is not cloned, it is directly used as the internal buffer. This allows us to replace the inifficent `Vec<u8>` to `JsArray` then to `TypedArray` (in typed arrays `from_iter`), with a `JsArrayBuffer` created from user data to `TypedArray`. With this `Vec<u8>` to `JsTypedArray` should be fully fixed as discussed in #2058.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
JsArrayBufferJsArrayBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ArrayBufferrust wrapper. It also provides a capability to construct aJsArrayBufferfrom a user defined blob of data (Vec<u8>) and it is not cloned, it is directly used as the internal buffer.This allows us to replace the inifficent
Vec<u8>toJsArraythen toTypedArray(in typed arraysfrom_iter), with aJsArrayBuffercreated from user data toTypedArray. With thisVec<u8>toJsTypedArrayshould be fully fixed as discussed in #2058.