Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Parse class private async generator methods #2220

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 5, 2022

Currently async generator class methods are not being parsed correctly. In comparison to the current main branch this only fixes a few tests, but after #2200 is merged, it should be aroud 1000 additional passing tests.

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser labels Aug 5, 2022
@raskad raskad added this to the v0.16.0 milestone Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,327 91,327 0
Passed 59,816 59,820 +4
Ignored 14,362 14,362 0
Failed 17,149 17,145 -4
Panics 0 0 0
Conformance 65.50% 65.50% +0.00%
Fixed tests (4):
test/language/statements/class/elements/syntax/valid/grammar-static-private-async-gen-meth-prototype.js [strict mode] (previously Failed)
test/language/statements/class/elements/syntax/valid/grammar-static-private-async-gen-meth-prototype.js (previously Failed)
test/language/expressions/class/elements/syntax/valid/grammar-static-private-async-gen-meth-prototype.js [strict mode] (previously Failed)
test/language/expressions/class/elements/syntax/valid/grammar-static-private-async-gen-meth-prototype.js (previously Failed)

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #2220 (038b19e) into main (fc885f1) will decrease coverage by 0.00%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
- Coverage   41.91%   41.91%   -0.01%     
==========================================
  Files         231      231              
  Lines       21497    21513      +16     
==========================================
+ Hits         9011     9017       +6     
- Misses      12486    12496      +10     
Impacted Files Coverage Δ
.../statement/declaration/hoistable/class_decl/mod.rs 24.18% <0.00%> (-0.29%) ⬇️
...arser/expression/primary/object_initializer/mod.rs 42.19% <36.36%> (+1.13%) ⬆️
...engine/src/syntax/parser/expression/primary/mod.rs 36.29% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix :) I will try to review the other PRs as soon as possible in the next days :)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@Razican
Copy link
Member

Razican commented Aug 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 5, 2022
Currently async generator class methods are not being parsed correctly. In comparison to the current main branch this only fixes a few tests, but after #2200 is merged, it should be aroud 1000 additional passing tests.
@bors
Copy link

bors bot commented Aug 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Parse class private async generator methods [Merged by Bors] - Parse class private async generator methods Aug 5, 2022
@bors bors bot closed this Aug 5, 2022
@bors bors bot deleted the parse-class-private-async-generator branch August 5, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants