Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - check history file exist if not create it #2245

Conversation

udhaykumarbala
Copy link
Contributor

This Pull Request fixes/closes #2223.

It changes the following:

  • Check the .boa_history file, if it is not exist then create the file before load history function to prevent the crash

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #2245 (038414b) into main (4f4a500) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2245   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files         234      234           
  Lines       22014    22014           
=======================================
  Hits         9092     9092           
  Misses      12922    12922           
Impacted Files Coverage Δ
boa_cli/src/main.rs 5.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@Razican Razican added bug Something isn't working cli Issues and PRs related to the Boa command line interface. labels Aug 21, 2022
@Razican Razican added this to the v0.16.0 milestone Aug 21, 2022
@raskad
Copy link
Member

raskad commented Aug 21, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 21, 2022
This Pull Request fixes/closes #2223.

It changes the following:

- Check the .boa_history file, if it is not exist then create the file before load history function to prevent the crash
@bors
Copy link

bors bot commented Aug 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title check history file exist if not create it [Merged by Bors] - check history file exist if not create it Aug 21, 2022
@bors bors bot closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Issues and PRs related to the Boa command line interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boa-cli crashes if history file does not exist
3 participants