[Merged by Bors] - fix computed property methods can call super methods #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
+ Coverage 41.33% 41.66% +0.32%
==========================================
Files 234 234
Lines 22019 21992 -27
==========================================
+ Hits 9101 9162 +61
+ Misses 12918 12830 -88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test262 conformance changesVM implementation
Fixed tests (30): |
|
Hi @creampnx-x! thanks for the contribution :) good catch. It seems that this is creating some new panics, unfortunately. You can check the panicking tests by using our guide in our contribution documentation. Most probably these panics are coming from that Let us know if you need some guidance, and once that's fixed and you're ready, you can put the PR as "Ready for review", and we will give it a further look. |
|
It seems these panics have been resolved when running the tests locally.Hope to review it if you have time. thanks. |
Razican
approved these changes
Sep 11, 2022
Razican
added
bug
Co-authored-by: Iban Eguia <razican@protonmail.ch>
Your suggestion has been submitted. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes: https://github.com/tc39/test262/blob/79e3bc5176b6f29a5aed3b7164a9c623a3a9a63b/test/language/computed-property-names/object/method/super.js This PR solves the bug of using the `super` keyword in the method attribute of object. When the environment is `None`, the `vm` gets the top element of `vm.stack` as `this`, such as: ```js var a = { f() { return super.m(); } }; var b = { m() { retrun "super"; } }; Object.setPrototypeOf(a, b); a.f(); // the top of stack is `a` let f = a.f; f(); // the top of stack is `global_this`, so `super` cannot be used ``` ### Can be improved What I think is that when I use `object.method()`, the engine should bind `this_object` to the `environment`, instead of using `vm.stack.last()...`. ### TODOS 1. `super` need to look for properties all the way to the end. Co-authored-by: creampnx_x <2270436024@qq.com>
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes: https://github.com/tc39/test262/blob/79e3bc5176b6f29a5aed3b7164a9c623a3a9a63b/test/language/computed-property-names/object/method/super.js
This PR solves the bug of using the
superkeyword in the method attribute of object. When the environment isNone, thevmgets the top element ofvm.stackasthis, such as:Can be improved
What I think is that when I use
object.method(), the engine should bindthis_objectto theenvironment, instead of usingvm.stack.last()....TODOS
superneed to look for properties all the way to the end.