Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexer: single-line-comment] Fix bug when single line comment is last line of file #228

Merged
merged 2 commits into from
Jan 20, 2020
Merged

[lexer: single-line-comment] Fix bug when single line comment is last line of file #228

merged 2 commits into from
Jan 20, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jan 19, 2020 •
edited
Loading

Fixes #221

@croraf croraf mentioned this pull request Jan 19, 2020
Closed
jasonwilliams
jasonwilliams approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this

@jasonwilliams jasonwilliams merged commit ce9af33 into boa-dev:master Jan 20, 2020
croraf added a commit to croraf/boa that referenced this pull request Jan 20, 2020
@croraf
[lexer: single-line-comment] Fix bug when single line comment is last…
496c8fe 
… line of file (boa-dev#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When single line comment is the last line in file the run fails
2 participants
@croraf @jasonwilliams