Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix double conversion to primitive in ToNumeric #2310

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix double conversion to primitive in ToNumeric #2310

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 26, 2022

This Pull Request changes the following:

  • Fix double conversion to primitive in ToNumeric.
  • Optimize object check in ToPrimitive.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Sep 26, 2022
@raskad raskad added this to the v0.17.0 milestone Sep 26, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,057 92,057 0
Passed 68,704 68,728 +24
Ignored 16,832 16,832 0
Failed 6,521 6,497 -24
Panics 0 0 0
Conformance 74.63% 74.66% +0.03%
Fixed tests (24): 
test/language/expressions/multiplication/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/multiplication/order-of-evaluation.js (previously Failed)
test/language/expressions/bitwise-and/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/bitwise-and/order-of-evaluation.js (previously Failed)
test/language/expressions/bitwise-or/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/bitwise-or/order-of-evaluation.js (previously Failed)
test/language/expressions/unsigned-right-shift/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/unsigned-right-shift/order-of-evaluation.js (previously Failed)
test/language/expressions/bitwise-xor/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/bitwise-xor/order-of-evaluation.js (previously Failed)
test/language/expressions/division/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/division/order-of-evaluation.js (previously Failed)
test/language/expressions/right-shift/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/right-shift/order-of-evaluation.js (previously Failed)
test/language/expressions/left-shift/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/left-shift/order-of-evaluation.js (previously Failed)
test/language/expressions/exponentiation/exp-operator-evaluation-order.js [strict mode] (previously Failed)
test/language/expressions/exponentiation/exp-operator-evaluation-order.js (previously Failed)
test/language/expressions/exponentiation/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/exponentiation/order-of-evaluation.js (previously Failed)
test/language/expressions/subtraction/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/subtraction/order-of-evaluation.js (previously Failed)
test/language/expressions/modulus/order-of-evaluation.js [strict mode] (previously Failed)
test/language/expressions/modulus/order-of-evaluation.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #2310 (07e9df5) into main (e9e85f5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files         237      237           
  Lines       22375    22375           
=======================================
  Hits         9218     9218           
  Misses      13157    13157
Impacted Files Coverage Δ
boa_engine/src/value/mod.rs 53.19% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@raskad raskad changed the title Fix double conversion to primitive in ToNumeric. Fix double conversion to primitive in ToNumeric Sep 26, 2022
jedel1043
jedel1043 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Razican
Razican approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks :)

@Razican
Copy link
Member

Razican commented Sep 26, 2022

Bors r+

bors bot pushed a commit that referenced this pull request Sep 26, 2022
@raskad
Fix double conversion to primitive in ToNumeric (#2310)
5b5498d 
This Pull Request changes the following:

- Fix double conversion to primitive in `ToNumeric`.
- Optimize object check in `ToPrimitive`.
@bors
Copy link

bors bot commented Sep 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix double conversion to primitive in ToNumeric [Merged by Bors] - Fix double conversion to primitive in ToNumeric Sep 26, 2022
@bors bors bot closed this Sep 26, 2022
@bors bors bot deleted the fix-to-numeric branch September 26, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @jedel1043