Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fixing the output for the test diffs in PRs #2320

Closed
wants to merge 2 commits into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 2, 2022

This PR fixes PR comments where negative numbers from 100 to 999 would be shown as -,999 instead of -999

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Oct 2, 2022
@Razican Razican added this to the v0.17.0 milestone Oct 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,351 92,351 0
Passed 68,926 68,926 0
Ignored 17,180 17,180 0
Failed 6,245 6,245 0
Panics 0 0 0
Conformance 74.63% 74.63% 0.00%

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #2320 (c80f3ac) into main (7f1d1a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2320   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files         237      237           
  Lines       22393    22393           
=======================================
  Hits         9213     9213           
  Misses      13180    13180           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

boa_tester/src/results.rs Outdated Show resolved Hide resolved
@Razican Razican requested a review from RageKnify October 2, 2022 11:59
@Razican
Copy link
Member Author

Razican commented Oct 4, 2022

bors r+

@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 4, 2022
bors bot pushed a commit that referenced this pull request Oct 4, 2022
This PR fixes PR comments where negative numbers from 100 to 999 would be shown as `-,999` instead of `-999`
@bors
Copy link

bors bot commented Oct 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixing the output for the test diffs in PRs [Merged by Bors] - Fixing the output for the test diffs in PRs Oct 4, 2022
@bors bors bot closed this Oct 4, 2022
@bors bors bot deleted the fix_test_output branch October 4, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted PR accepted for Hacktoberfest test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants