Fixed compilation without "wasm-bindgen" feature #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error seems unrelated? |
|
CI error is due to the update in |
|
@Razican eugh, i thought we switched "pedantic" errors off, that lint looks like it falls under the "pedantic" group. maybe the wasm file needs to copy https://github.com/jasonwilliams/boa/blob/master/src/lib/lib.rs#L2-L4 |
|
could you rebase @adumbidiot ? ive merged some clippy fixes |
|
@jasonwilliams done |
jasonwilliams
approved these changes
Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234. I put the wasm-related stuff in its own module. I also conditionally re-exported the contents of this module, as the
evaluatefunction is public and I was unsure if making it private would break semver.