Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Removed the "VM Implementation" headline for Test262 #2364

Closed
wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 21, 2022

We were always getting a "VM Implementation" headline in Test262 results for PRs. This was a leftover from the time when we had 2 distinct implementations for the execution. This is no longer the case, so we can remove it to reduce clutter.

@Razican Razican added enhancement New feature or request test Issues and PRs related to the tests. labels Oct 21, 2022
@Razican Razican added this to the v0.17.0 milestone Oct 21, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,095 69,095 0
Ignored 18,182 18,182 0
Failed 6,106 6,106 0
Panics 0 0 0
Conformance 73.99% 73.99% 0.00%

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2364 (6f2431a) into main (d51fee7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2364   +/-   ##
=======================================
  Coverage   39.84%   39.84%           
=======================================
  Files         242      242           
  Lines       23242    23242           
=======================================
  Hits         9260     9260           
  Misses      13982    13982           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 21, 2022
We were always getting a "VM Implementation" headline in Test262 results for PRs. This was a leftover from the time when we had 2 distinct implementations for the execution. This is no longer the case, so we can remove it to reduce clutter.
@bors
Copy link

bors bot commented Oct 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Removed the "VM Implementation" headline for Test262 [Merged by Bors] - Removed the "VM Implementation" headline for Test262 Oct 21, 2022
@bors bors bot closed this Oct 21, 2022
@bors bors bot deleted the no_vm_test262 branch October 21, 2022 16:02
@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants