Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement member accessors in initializer of for loops #2381

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This Pull Request implements member accessors in for ... in and for ... of loops. This unlocks patterns like:

let obj = {a: 0, b: 1};

for (obj.a of [1,2,3]) {
}

console.log(obj.a) // 3

@jedel1043 jedel1043 added enhancement New feature or request vm Issues and PRs related to the Boa Virtual Machine. ast Issue surrounding the abstract syntax tree labels Oct 26, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Oct 26, 2022
@jedel1043 jedel1043 changed the title Implement member accessors on for loops Implement member accessors in initializer of for loops Oct 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,150 69,176 +26
Ignored 18,352 18,352 0
Failed 6,287 6,261 -26
Panics 0 0 0
Conformance 73.73% 73.76% +0.03%
Fixed tests (26):
test/language/statements/for-in/head-lhs-member.js [strict mode] (previously Failed)
test/language/statements/for-in/head-lhs-member.js (previously Failed)
test/language/statements/for-of/head-lhs-async-dot.js [strict mode] (previously Failed)
test/language/statements/for-of/head-lhs-async-dot.js (previously Failed)
test/language/statements/for-of/head-lhs-member.js [strict mode] (previously Failed)
test/language/statements/for-of/head-lhs-member.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-10.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-10.js (previously Failed)
test/language/statements/class/elements/privatefieldset-evaluation-order-2.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-evaluation-order-2.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-6.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-6.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-9.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-9.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-7.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-7.js (previously Failed)
test/language/statements/class/elements/privatefieldset-evaluation-order-3.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-evaluation-order-3.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-11.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-11.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-8.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-8.js (previously Failed)
test/language/expressions/assignment/target-super-identifier-reference-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/target-super-identifier-reference-null.js (previously Failed)
test/language/expressions/assignment/target-super-computed-reference-null.js [strict mode] (previously Failed)
test/language/expressions/assignment/target-super-computed-reference-null.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2381 (9bd66f5) into main (89e3081) will increase coverage by 0.04%.
The diff coverage is 35.00%.

@@            Coverage Diff             @@
##             main    #2381      +/-   ##
==========================================
+ Coverage   39.88%   39.93%   +0.04%     
==========================================
  Files         304      304              
  Lines       23317    23308       -9     
==========================================
+ Hits         9300     9307       +7     
+ Misses      14017    14001      -16     
Impacted Files Coverage Δ
boa_engine/src/syntax/ast/expression/mod.rs 40.00% <ø> (-0.30%) ⬇️
...a_engine/src/syntax/ast/statement/iteration/mod.rs 40.00% <0.00%> (-4.45%) ⬇️
...engine/src/syntax/parser/expression/primary/mod.rs 35.16% <ø> (ø)
boa_engine/src/syntax/parser/expression/unary.rs 52.83% <0.00%> (ø)
...syntax/parser/statement/iteration/for_statement.rs 36.69% <0.00%> (+0.66%) ⬆️
boa_engine/src/vm/opcode/mod.rs 50.00% <ø> (ø)
boa_engine/src/syntax/ast/pattern.rs 36.72% <11.42%> (+4.58%) ⬆️
boa_engine/src/syntax/ast/expression/access.rs 23.07% <22.72%> (+1.76%) ⬆️
...e/src/syntax/ast/expression/operator/assign/mod.rs 16.21% <40.00%> (-0.14%) ⬇️
boa_engine/src/bytecompiler/mod.rs 29.41% <40.15%> (+0.20%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
This Pull Request implements member accessors in `for ... in` and `for ... of` loops. This unlocks patterns like:

```Javascript
let obj = {a: 0, b: 1};

for (obj.a of [1,2,3]) {
}

console.log(obj.a) // 3
```
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement member accessors in initializer of for loops [Merged by Bors] - Implement member accessors in initializer of for loops Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the member-accessors branch October 26, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants