-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix async tests result values #2406
Conversation
Test262 conformance changes
Broken tests (11):
|
Codecov Report
@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
- Coverage 38.85% 38.85% -0.01%
==========================================
Files 313 313
Lines 23846 23846
==========================================
- Hits 9266 9265 -1
- Misses 14580 14581 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
So, there were some tests that weren't reporting the result of async evaluations correctly. This PR fixes this. It also ignores tests with the `IsHTMLDDA` feature, since we haven't implemented it. On another note, this also changes the symbols of the test suite to 'F' (failed) and '-' (ignored), which is clearer for colorless terminals.
Pull request successfully merged into main. Build succeeded: |
So, there were some tests that weren't reporting the result of async evaluations correctly. This PR fixes this. It also ignores tests with the
IsHTMLDDA
feature, since we haven't implemented it.On another note, this also changes the symbols of the test suite to 'F' (failed) and '-' (ignored), which is clearer for colorless terminals.