[Merged by Bors] - Add early error for yield in GeneratorExpression parameters
#2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changes
Fixed tests (2): |
Codecov Report
@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 38.74% 38.69% -0.06%
==========================================
Files 313 314 +1
Lines 23856 23887 +31
==========================================
Hits 9244 9244
- Misses 14612 14643 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -130,6 +130,14 @@ where | |||
| params_start_position, | |||
| )?; | |||
|
|
|||
| // It is a Syntax Error if FormalParameters Contains YieldExpression is true. | |||
There was a problem hiding this comment.
// https://tc39.es/ecma262/#sec-generator-function-definitions-static-semantics-early-errors
I think the above comment is also pointing to function definitions not generator function definitions which is slightly different.
jasonwilliams
approved these changes
Nov 7, 2022
HalidOdat
approved these changes
Nov 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
This Pull Request changes the following: - Add early error for `yield` in `GeneratorExpression` parameters
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
yield in GeneratorExpression parametersyield in GeneratorExpression parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
yieldinGeneratorExpressionparameters