Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - JsArrayBuffer take method and docs #2454

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - JsArrayBuffer take method and docs #2454

wants to merge 3 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Nov 22, 2022

This Pull Request is related to the #2058 and the discussion in the discord chat.

It changes the following:

  • Adds a take method to JsArrayBuffer
  • Builds out JsArrayBuffer docs
  • Adds a JsArrayBuffer::take() example to jsarraybuffer.rs in boa_examples

@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #2454 (ccb9672) into main (385eaa0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2454   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files         330      330           
  Lines       34932    34935    +3     
=======================================
+ Hits        18354    18357    +3     
  Misses      16578    16578
Impacted Files Coverage Δ
boa_engine/src/object/builtins/jsarraybuffer.rs 0.00% <0.00%> (ø)
boa_gc/src/cell.rs 63.84% <0.00%> (-0.57%) ⬇️
boa_examples/src/bin/symbol_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/loadfile.rs
boa_examples/src/bin/classes.rs
boa_examples/src/bin/jsdate.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/jsmap.rs 0.00% <0.00%> (ø)
boa_engine/src/object/mod.rs 46.09% <0.00%> (+0.10%) ⬆️
boa_engine/src/environments/runtime.rs 48.42% <0.00%> (+0.70%) ⬆️
boa_engine/src/value/display.rs 87.31% <0.00%> (+0.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics API labels Nov 22, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Nov 22, 2022
HalidOdat
HalidOdat reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some small documentation nitpicks :)

boa_engine/src/object/builtins/jsarraybuffer.rs Outdated Show resolved Hide resolved
boa_engine/src/object/builtins/jsarraybuffer.rs Outdated Show resolved Hide resolved
boa_engine/src/object/builtins/jsarraybuffer.rs Outdated Show resolved Hide resolved
boa_engine/src/object/builtins/jsarraybuffer.rs Outdated Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

raskad
raskad approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

@raskad
Copy link
Member

raskad commented Nov 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 24, 2022
@nekevss
JsArrayBuffer take method and docs (#2454)
8c88281 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request is related to the #2058 and the discussion in the discord chat.

It changes the following:

- Adds a `take` method to `JsArrayBuffer`
- Builds out `JsArrayBuffer` docs
- Adds a `JsArrayBuffer::take()` example to `jsarraybuffer.rs` in `boa_examples`
@bors
Copy link

bors bot commented Nov 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title JsArrayBuffer take method and docs [Merged by Bors] - JsArrayBuffer take method and docs Nov 24, 2022
@bors bors bot closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 Awaiting requested review from jedel1043

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nekevss @raskad @HalidOdat @jedel1043