Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use opcode table rather than match #2501

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Use opcode table rather than match #2501

wants to merge 4 commits into from
+18 −18

Commits on Dec 26, 2022

  1. Use opcode table rather than match 

    After decoding an opcode, `match` is used to find a proper `execute`
function for the opcode. But, the `match` may not be able to be
optimized into a linear table jump by rust compiler, so it may use
multiple branches to find the function.

This change makes the opcode to use a table explicitly. This change
improves the benchmark score of Richards about 1-2% (22.8 -> 23.2).
    @tunz @jedel1043
    tunz authored and jedel1043 committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    be385f9 View commit details
    Browse the repository at this point in the history

  2. Addressing comments

    @tunz @jedel1043
    tunz authored and jedel1043 committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    ee9a26b View commit details
    Browse the repository at this point in the history

  3. single line for each variant

    @tunz @jedel1043
    tunz authored and jedel1043 committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    988283d View commit details
    Browse the repository at this point in the history

  4. Renaming

    @tunz @jedel1043
    tunz authored and jedel1043 committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    171edd7 View commit details
    Browse the repository at this point in the history