Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Pass a receiver value in property getter opcodes #2516

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 5, 2023

This Pull Request changes the following:

  • Pass a receiver value to the object get function in the GetPropertyBy* opcodes. The receiver value may be different from the object, because ToObject is not called on it.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jan 5, 2023
@raskad raskad added this to the v0.17.0 milestone Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,188 94,188 0
Passed 70,164 70,166 +2
Ignored 18,605 18,605 0
Failed 5,419 5,417 -2
Panics 0 0 0
Conformance 74.49% 74.50% +0.00%
Fixed tests (2):
test/language/function-code/10.4.3-1-106.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-104.js [strict mode] (previously Failed)

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2516 (4321922) into main (1b04c9e) will decrease coverage by 0.07%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #2516      +/-   ##
==========================================
- Coverage   50.68%   50.60%   -0.08%     
==========================================
  Files         358      359       +1     
  Lines       36265    36339      +74     
==========================================
+ Hits        18380    18389       +9     
- Misses      17885    17950      +65     
Impacted Files Coverage Δ
boa_engine/src/vm/opcode/get/property.rs 65.62% <57.14%> (-1.05%) ⬇️
boa_ast/src/visitor.rs 10.58% <0.00%> (-0.59%) ⬇️
boa_gc/src/cell.rs 63.84% <0.00%> (-0.57%) ⬇️
boa_engine/src/object/mod.rs 44.22% <0.00%> (-0.11%) ⬇️
boa_examples/src/bin/loadstring.rs
boa_examples/src/bin/closures.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/modulehandler.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/code_block.rs 33.28% <0.00%> (+0.13%) ⬆️
boa_ast/src/position.rs 93.10% <0.00%> (+41.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 7, 2023
This Pull Request changes the following:

- Pass a receiver value to the object `get` function in the `GetPropertyBy*` opcodes. The receiver value may be different from the object, because `ToObject` is not called on it.
@bors
Copy link

bors bot commented Jan 7, 2023

Build failed:

@raskad
Copy link
Member Author

raskad commented Jan 7, 2023

bors retry

bors bot pushed a commit that referenced this pull request Jan 7, 2023
This Pull Request changes the following:

- Pass a receiver value to the object `get` function in the `GetPropertyBy*` opcodes. The receiver value may be different from the object, because `ToObject` is not called on it.
@bors
Copy link

bors bot commented Jan 7, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Pass a receiver value in property getter opcodes [Merged by Bors] - Pass a receiver value in property getter opcodes Jan 7, 2023
@bors bors bot closed this Jan 7, 2023
@bors bors bot deleted the pass-receiver-get-property-opcodes branch January 7, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants