Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Break Opcode and ByteCompiler changes #2523

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Break Opcode and ByteCompiler changes #2523

wants to merge 8 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 8, 2023

Hi all! 😄

This Pull Request addresses #2424. There are also a few changes made to the ByteCompiler, the majority of which are involving JumpControlInfo.

It changes the following:

  • Adds Break Opcode
  • Shifts compile_stmt into the statement module.
  • Moves JumpControlInfo to it's own module.

@nekevss nekevss added bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine. labels Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited
Loading

Codecov Report

Merging #2523 (8e984b6) into main (082d362) will increase coverage by 0.37%.
The diff coverage is 83.63%.

@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
+ Coverage   51.50%   51.87%   +0.37%     
==========================================
  Files         358      362       +4     
  Lines       35755    35846      +91     
==========================================
+ Hits        18414    18595     +181     
+ Misses      17341    17251      -90
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/mod.rs 62.93% <ø> (-1.02%) ⬇️
boa_engine/src/vm/code_block.rs 33.42% <ø> (+0.28%) ⬆️
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/jump/mod.rs 39.13% <ø> (ø)
boa_engine/src/vm/opcode/mod.rs 70.00% <ø> (ø)
boa_engine/src/bytecompiler/statement/labelled.rs 48.57% <48.57%> (ø)
boa_engine/src/bytecompiler/statement/continue.rs 70.83% <50.00%> (+0.65%) ⬆️
boa_engine/src/bytecompiler/jump_control.rs 85.79% <85.79%> (ø)
boa_engine/src/bytecompiler/statement/break.rs 92.30% <92.30%> (ø)
boa_engine/src/bytecompiler/statement/mod.rs 97.05% <96.96%> (+18.93%) ⬆️
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nekevss nekevss added this to the v0.17.0 milestone Jan 8, 2023
jasonwilliams
jasonwilliams approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM
Nice work!

jedel1043
jedel1043 requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I opened some discussions about some improvements that could be made :)

boa_engine/src/bytecompiler/jump_control.rs Outdated Show resolved Hide resolved
boa_engine/src/bytecompiler/jump_control.rs Outdated Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 12, 2023
@nekevss
Break Opcode and ByteCompiler changes (#2523)
26d21fd 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

Hi all! 😄

This Pull Request addresses #2424. There are also a few changes made to the `ByteCompiler`, the majority of which are involving `JumpControlInfo`.

It changes the following:

- Adds `Break` Opcode
- Shifts `compile_stmt` into the `statement` module. 
- Moves `JumpControlInfo` to it's own module.
@bors
Copy link

bors bot commented Jan 12, 2023

Build failed:

@jedel1043
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jan 12, 2023
@nekevss
Break Opcode and ByteCompiler changes (#2523)
989edd4 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

Hi all! 😄

This Pull Request addresses #2424. There are also a few changes made to the `ByteCompiler`, the majority of which are involving `JumpControlInfo`.

It changes the following:

- Adds `Break` Opcode
- Shifts `compile_stmt` into the `statement` module. 
- Moves `JumpControlInfo` to it's own module.
@bors
Copy link

bors bot commented Jan 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Break Opcode and ByteCompiler changes [Merged by Bors] - Break Opcode and ByteCompiler changes Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@raskad raskad Awaiting requested review from raskad

@RageKnify RageKnify Awaiting requested review from RageKnify

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @jedel1043 @jasonwilliams