[Merged by Bors] - Improve the design of ephemerons in our GC #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
technical debt
execution
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
+ Coverage 49.99% 50.15% +0.16%
==========================================
Files 379 379
Lines 37642 37660 +18
==========================================
+ Hits 18819 18889 +70
+ Misses 18823 18771 -52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nekevss
reviewed
Jan 14, 2023
There was a problem hiding this comment.
I'm going to try and look at this in more depth and play around with it this weekend, but I wanted to leave some early comments.
On the topic of improvements/clarity changes, I was thinking about the current names of some structs. In particular, thoughts on switching GcCell to GcRefCell, GcCellRef to GcRef, and GcCellRefMut to GcRefMut?
nekevss
reviewed
Jan 14, 2023
nekevss
reviewed
Jan 14, 2023
I like it! The current names make |
jedel1043
force-pushed
the
gc-improvements
branch
from
4fc736c to
8716dab
Compare
raskad
approved these changes
Jan 18, 2023
jedel1043
force-pushed
the
gc-improvements
branch
from
8716dab to
51c4251
Compare
nekevss
requested changes
Jan 20, 2023
nekevss
approved these changes
Jan 22, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
This PR changes the following: - Modifies `EphemeronBox` to be more akin to `GcBox`, with its own header, roots and markers. This also makes it more similar to [Racket's](https://docs.racket-lang.org/reference/ephemerons.html) implementation. - Removes `EPHEMERON_QUEUE`. - Ephemerons are now tracked on a special `weak_start` linked list, instead of `strong_start` which is where all other GC boxes live. - Documents all unsafe blocks. - Documents our current garbage collection algorithm. I hope this'll clarify a bit what exactly are we doing on every garbage collection. - Renames/removes some functions.
|
Build failed: |
jedel1043
force-pushed
the
gc-improvements
branch
from
533d7c6 to
211f150
Compare
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
This PR changes the following: - Modifies `EphemeronBox` to be more akin to `GcBox`, with its own header, roots and markers. This also makes it more similar to [Racket's](https://docs.racket-lang.org/reference/ephemerons.html) implementation. - Removes `EPHEMERON_QUEUE`. - Ephemerons are now tracked on a special `weak_start` linked list, instead of `strong_start` which is where all other GC boxes live. - Documents all unsafe blocks. - Documents our current garbage collection algorithm. I hope this'll clarify a bit what exactly are we doing on every garbage collection. - Renames/removes some functions.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
EphemeronBoxto be more akin toGcBox, with its own header, roots and markers. This also makes it more similar to Racket's implementation.EPHEMERON_QUEUE.weak_startlinked list, instead ofstrong_startwhich is where all other GC boxes live.