Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement binary in operation with private names #2582

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement binary in operation with private names #2582

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Feb 1, 2023

This Pull Request changes the following:

  • Implement binary in operation with private names.
  • Adding a separate BinaryInPrivate expression in addition to the existing Binary expression seems like the best way to implement this in a typesafe manner. Other methods like adding an enum for the Binary lhs result in having to make assertions.

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser vm Issues and PRs related to the Boa Virtual Machine. labels Feb 1, 2023
@raskad raskad added this to the v0.17.0 milestone Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,722 70,742 +20
Ignored 18,622 18,622 0
Failed 4,861 4,841 -20
Panics 0 0 0
Conformance 75.07% 75.09% +0.02%
Fixed tests (20): 
test/language/expressions/in/private-field-presence-field.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-field.js (previously Failed)
test/language/expressions/in/private-field-presence-accessor-shadowed.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-accessor-shadowed.js (previously Failed)
test/language/expressions/in/private-field-rhs-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-rhs-unresolvable.js (previously Failed)
test/language/expressions/in/private-field-rhs-await-absent.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-rhs-await-absent.js (previously Failed)
test/language/expressions/in/private-field-rhs-non-object.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-rhs-non-object.js (previously Failed)
test/language/expressions/in/private-field-presence-accessor.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-accessor.js (previously Failed)
test/language/expressions/in/private-field-rhs-yield-present.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-rhs-yield-present.js (previously Failed)
test/language/expressions/in/private-field-presence-method-shadowed.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-method-shadowed.js (previously Failed)
test/language/expressions/in/private-field-presence-method.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-method.js (previously Failed)
test/language/expressions/in/private-field-presence-field-shadowed.js [strict mode] (previously Failed)
test/language/expressions/in/private-field-presence-field-shadowed.js (previously Failed)

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #2582 (dc6d78f) into main (b76050d) will decrease coverage by 0.09%.
The diff coverage is 5.71%.

@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
- Coverage   49.85%   49.76%   -0.09%     
==========================================
  Files         384      384              
  Lines       38012    38081      +69     
==========================================
+ Hits        18949    18950       +1     
- Misses      19063    19131      +68
Impacted Files Coverage Δ
boa_ast/src/expression/mod.rs 49.57% <0.00%> (-1.29%) ⬇️
boa_ast/src/expression/operator/binary/mod.rs 55.00% <0.00%> (-45.00%) ⬇️
boa_ast/src/visitor.rs 12.50% <0.00%> (-0.72%) ⬇️
boa_engine/src/bytecompiler/expression/binary.rs 72.30% <0.00%> (-8.73%) ⬇️
boa_engine/src/bytecompiler/expression/mod.rs 51.87% <0.00%> (-0.57%) ⬇️
boa_engine/src/vm/code_block.rs 30.55% <ø> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/binary_ops/mod.rs 59.18% <0.00%> (-23.68%) ⬇️
boa_engine/src/vm/opcode/mod.rs 45.45% <ø> (ø)
boa_parser/src/parser/expression/mod.rs 83.40% <17.39%> (-7.60%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 1, 2023
@raskad
Implement binary in operation with private names (#2582)
3725ff8 
This Pull Request changes the following:

- Implement binary `in` operation with private names.
- Adding a separate `BinaryInPrivate` expression in addition to the existing `Binary` expression seems like the best way to implement this in a typesafe manner. Other methods like adding an enum for the `Binary` lhs result in having to make assertions.
@bors
Copy link

bors bot commented Feb 1, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement binary in operation with private names [Merged by Bors] - Implement binary in operation with private names Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the in-op-private branch February 1, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
enhancement New feature or request parser Issues surrounding the parser vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @nekevss