Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feature flag on builtins console import #2584

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Feature flag on builtins console import #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f1ca34
Feature flag on builtins console import
nekevss Feb 2, 2023
8b39952
Modify Lint (No features)
nekevss Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Lint (All features)
run: cargo clippy --all-features --all-targets
- name: Lint (No features)
run: cargo clippy --no-default-features --all-targets
run: cargo clippy -p boa_engine --no-default-features --all-targets
- name: Generate documentation
run: cargo doc -v --document-private-items --all-features
- name: Build
Expand Down
4 changes: 3 additions & 1 deletion boa_engine/src/builtins/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ use crate::{
uri::{DecodeUri, DecodeUriComponent, EncodeUri, EncodeUriComponent},
weak::WeakRef,
},
console::Console,
context::intrinsics::{Intrinsics, StandardConstructor, StandardConstructors},
js_string,
native_function::{NativeFunction, NativeFunctionPointer},
Expand All @@ -97,6 +96,9 @@ use crate::{
Context, JsResult, JsString, JsValue,
};

#[cfg(feature = "console")]
use crate::console::Console;

/// A [Well-Known Intrinsic Object].
///
/// Well-known intrinsics are built-in objects that are explicitly referenced by the algorithms of
Expand Down