Improved parser error messages #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwilliams
approved these changes
Mar 6, 2020
I also took the opportunity to idiomatize some derives. Since derives are part of the definition of a structure/type, they should go with the definition, and not with the comments.
|
Hi, I re-based to master. Checking the official documentation, this is the common practice: https://doc.rust-lang.org/rust-by-example/trait/derive.html |
|
Not ignoring this PR, I’m just working on refactoring the parser right now, so some of these are on hold |
|
Closing as superseeded by jasonwilliams#283 |
jasonwilliams
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Ported #261 to the new parser * Fixed some comments * More comment improvements * Fixed one error in the parser, and improved error messages * Fix the `next_if` function Also, update documentation. Co-Authored-By: HalidOdat <halidodat@gmail.com> * Improved one particular error * Fixed function declaration parsing Co-authored-by: HalidOdat <halidodat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser error messages now also include the line and the column where the offending lexer tokens started. This should make it easier to debug JavaScript code, and also the limitations of the engine itself.
I also took the opportunity to idiomatize some derives. Since derives
are part of the definition of a structure/type, they should go with
the definition, and not with the comments.