[Merged by Bors] - Handle surrogates in String.fromCodePoint
#2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
execution
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
+ Coverage 49.20% 49.76% +0.55%
==========================================
Files 390 383 -7
Lines 39562 39179 -383
==========================================
+ Hits 19467 19496 +29
+ Misses 20095 19683 -412
... and 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
This Pull Request fixes #2657. It changes the following: - Handles surrogates when trying to convert f64 codepoints to u16. - Replaces `abs().floor()` with `truncate` on `is_float_integer`.
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
This Pull Request fixes #2657. It changes the following: - Handles surrogates when trying to convert f64 codepoints to u16. - Replaces `abs().floor()` with `truncate` on `is_float_integer`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
String.fromCodePointString.fromCodePoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #2657.
It changes the following:
abs().floor()withtruncateonis_float_integer.